Problem/Motivation

Check for update and Sync metadata are visible to users but they do not have access to use those operations.

Steps to reproduce

  • Install & Configure Acquia DAM module.
  • Add few DAM assets.
  • Create new role with permission to add node/media.
  • Login with new user.
  • Visit `/admin/content/dam-media`, update and Sync metadata are visible for assets operations list.

Proposed resolution

We should not display the operations in here when the user doesn’t have permission for those operations.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork acquia_dam-3558231

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rajeshreeputra created an issue. See original summary.

rajeshreeputra opened merge request !222

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Active » Needs review
ankitv18’s picture

ankitv18 commented
Status: Needs review » Needs work

Left minor suggestion, also tests are failing

Concern: Clearing the cache make this fully functional but can't we implement this in more optimal way to clear the cache while authenticating the DAM.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs work » Needs review

Regarding the cache implementation suggestion: since authentication is checked dynamically, doubtful that a caching solution will work effectively for entity operations.

Refactored the DAM Media Overview page test and requesting review.

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

Alright
Then changes looking fine to me

amangrover90’s picture

amangrover90 commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.