https://git.drupalcode.org/project/restrict_by_ip/-/jobs/5813005

Issue fork restrict_by_ip-3534706

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

darvanen created an issue. See original summary.

darvanen opened merge request !13

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: darvanen » Unassigned
Status: Active » Needs work
Issue tags: +Novice

Still some phpcs and cspell issues. @darvanen maybe the community can help? (Hope the unassing is fine after 1Y to help you - no bad intentions!)

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

No offence taken!
I self-assigned at the height of drive by phpcbf with no follow-ups and then obviously dropped the ball.

kieran.cott made their first commit to this issue’s fork.

kieran.cott’s picture

kieran.cott commented

I've resolved the various phpcs and cspell issues.
Some previous maintainer usernames were being flagged by cspell, so I've changed:

- Matt Rice - [ymmatt](https://www.drupal.org/user/92457)
- Bobby Kramer - [panthar](https://www.drupal.org/u/panthar)

to

- Matt Rice - [Drupal profile](https://www.drupal.org/user/92457)
- Bobby Kramer - [Drupal profile](https://www.drupal.org/u/panthar)

in README.md - hope that's still okay for proper attribution.

Edit: Looks like there's some additional PHPStan errors to resolve next...

kieran.cott’s picture

kieran.cott commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Nice work, I've reviewed everything one by one and everything looks great now, thanks @kieran.cott!

Just made one last cosmetic change.

  • darvanen committed 9d168531 on 8.x-4.x 
    task: #3534706 phpcs failures

By: darvanen
By: anybody
By: kieran.cott
darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Reviewed & tested by the community » Fixed

Thank you both for the effort!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.