Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Function names must be prefixed by the name of the module which defines them to avoid conflict with other modules; that is also true for functions whose name starts with an underscore.
Comments
Comment #1
apadernoThe only exception is for theme functions, of course, whose name must start with theme_.
Still, to avoid conflicts, the theme functions defined by kaltura.module should have a name starting with theme_kaltura_.
Comment #2
apadernoThis is not exactly a bug, but it can cause problems, and therefore it must be changed.
Comment #3
Dave ReidIf it's not following the coding standards, it's definitely a bug, especially with something that could cause name collisions. I mean this in the best way possible, but from the number of issues in this module's queue for things that do not follow Drupal module coding/standards, it seems like the developers really need to take a look at core modules and the coding standards. There are lots of unacceptable bugs.
Comment #4
Zohar.Babin CreditAttribution: Zohar.Babin commentedKiam, David,
This bug/task has already been applied on the code, but yet to be committed to the CVS.
We do our best to fix all issues as fast as we can, as well as comply the coding standards.
Gonen
Comment #5
Dave ReidSounds good, just make sure to keep us updated in the issue statuses when each issue is fixed in CVS. Thanks gonen!
Comment #6
apadernoIf the category has been changed back, then also the title should be changed.
Comment #7
Zohar.Babin CreditAttribution: Zohar.Babin commentedall functions prefixed in 6.x-1.4 and 5.x-1.3
Comment #8
xurizaemonThis issue was apparently never really resolved, or reappeared in a later checkin.
The following functions are incorrectly named as of current DRUPAL-6--2 and DRUPAL-6--1 - I haven't included here function names which will be renamed as a result of #877444: Module namespacing.
DRUPAL-6--2
DRUPAL-6--1
Comment #9
apadernoThey are a lot of functions. Thank you, grobot, to re-open this issue.
Comment #10
xurizaemonFor DRUPAL-6--2. Partially tested only. Probably requires an update hook to force clearing the theme cache, as we have theme functions which are renamed here.
Comment #11
xurizaemonupdated patch committed to DRUPAL-6--2 in http://drupal.org/cvs?commit=452164
Comment #12
xurizaemonAdditional to previous patch.
Comment #13
xurizaemonFrom #1009044: Fix for advanced editor theme
Comment #14
xurizaemon'git diff' not so informative post-commit ... let's try this one :)
Comment #15
xurizaemonIn field_kaltura.module, function kaltura_is_kaltura_field() should be moved to kaltura.module or renamed to field_kaltura_is_kaltura_field() (which will be an awesome function name btw)
Comment #16
apadernoI am closing this issue since it's for a Drupal version that isn't supported.