[11.1.x] Add BC stubs for Hook ordering.

This seems critical for 11.1.x and very nice to have for 11.0.x and lower.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Appears to have pipeline issues

I tried too and got a “file has been changed”

Wonder if 11.1x branch permission?

Moving to NW because all the tests appear to be failing

PHP Fatal error: Uncaught Error: Call to undefined method Drupal\Core\Hook\Attribute\Hook::setMethod() in /builds/issue/drupal-3512835/core/lib/Drupal/Core/Hook/HookCollectorPass.php:289

All seems good now.

Committed to 11.1.x and backported to 10.5.x and 11.0.x

Did the PREFIX and SUFFIX need backporting?

The 10.5.x backport failed - we're using readonly properties here which aren't allowed on the versions of PHP 10.x supports

This MR did a lot more than what we need to for the BC support.
We absolutely don't need all these new attributes.
We only need to make the existing attributes compatible with new modules.
We did have a very clear plan for this, which we somehow forgot.

Missing attributes are ok, because we call ->getAttributes() with a type parameter. Only attributes classes with incompatible constructor signature are a problem.

We should either revert this and do again, or remove all the changes we don't need.
And before the next release for 11.1.x or 11.0.x. (if that has not already happened, I am not following).

(recap of what I said in slack)

My concern is this:

We have a grace period before 11.2.0 to tweak api details of the new attributes and API features we are adding.
But whatever we put into older versions of Drupal may get released before 11.2.0, as part of a minor release. At that point we can no longer change these, so we are cutting that grace period short.

Also for disruptive future changes to the new attributes, we now will need to cater to the 10.5.x, 11.0.x and 11.1.x as well.
Worse, we could have contrib modules written for 11.2.x that are compatible with 10.5.x but not with 10.6.x, or vice versa, because we just backported another change.

You are correct about order classes though, we do need these in any branch that collects hook attributes.
(more below)

I'm not sure what plan you are referring to

I remember a discussion where we determined that missing attributes are not a problem, only incompatible constructors.
The conclusion was that we update existing attributes in older versions where they exist, to allow alternative parameters, but that we don't backport all new attribute classes.

For concerns with phpstan, I am sure this can be handled in some way.

we backported Hook and LegacyHook to 10.4 as part of the original OOP hook initiative

I would have complained about backporting hook attribute to 10.x, but I probably did not pay attention at the time.

In this case the Order classes are required otherwise there would be a fatal, and since we backported Hook already we need to backport those as well to all branches.

This is correct, we do have to backport the order classes to any branch which has the Hook attribute class, OR any branch where we actually collect hook attributes.
But this also means: If we had not backported the Hook class to 10.x, we now would not have to create BC stubs for 10.x.

None of the plumbing for collection or ordering was backported, why are you concerned about backporting these classes, what could it possibly affect, they are not used.

The attribute classes are part of public API, the plumbing is not.
In general, releasing public API features is easy, the problem is that we cannot easily remove or change them later.

Follow-up here: #3523385: [11.1] Reduce hook attribute order BC stubs to the minimum necessary