Problem/Motivation

Fix the following PHPStan issues:

------ ---------------------------------------------------------------------------------------------------------
  Line   contrib/field_group_migrate/src/Plugin/migrate/destination/d7/FieldGroup.php
 ------ ---------------------------------------------------------------------------------------------------------
  45     Deprecated in PHP 8.4: Parameter #5 $migration (Drupal\migrate\Plugin\MigrationInterface) is implicitly
         nullable via default value null.
  106    Deprecated in PHP 8.4: Parameter #1 $migration (Drupal\migrate\Plugin\MigrationInterface) is implicitly
         nullable via default value null.
 ------ ---------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------
  Line   contrib/field_group_migrate/src/Plugin/migrate/source/d7/FieldGroup.php
 ------ ---------------------------------------------------------------------------------------------------------
  57     Deprecated in PHP 8.4: Parameter #5 $migration (Drupal\migrate\Plugin\MigrationInterface) is implicitly
         nullable via default value null.
 ------ ---------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------
  Line   field_group.module
 ------ --------------------------------------------------------------------------------------------------------------
  358    Call to static method isDisabled() on an unknown class Drupal\ds\Ds.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
  426    Deprecated in PHP 8.4: Parameter #2 $form_state (Drupal\Core\Form\FormStateInterface) is implicitly nullable
         via default value null.
  493    Deprecated in PHP 8.4: Parameter #2 $form_state (Drupal\Core\Form\FormStateInterface) is implicitly nullable
         via default value null.
  637    Deprecated in PHP 8.4: Parameter #2 $vars (array) is implicitly nullable via default value null.
  730    Deprecated in PHP 8.4: Parameter #2 $vars (array) is implicitly nullable via default value null.
  824    No error to ignore is reported on line 824.
  877    Deprecated in PHP 8.4: Parameter #2 $display (Drupal\Core\Entity\Display\EntityDisplayInterface) is
         implicitly nullable via default value null.
 ------ --------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------
  Line   modules/field_group_accordion/src/Plugin/field_group/FieldGroupFormatter/Accordion.php
 ------ ---------------------------------------------------------------------------------------------------------
  99     Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0
         required.
 ------ ---------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------
  Line   modules/field_group_accordion/src/Plugin/field_group/FieldGroupFormatter/AccordionItem.php
 ------ ---------------------------------------------------------------------------------------------------------
  133    Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0
         required.
 ------ ---------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------
  Line   src/FormatterHelper.php
 ------ --------------------------------------------------------------------------------------------------------------
  63     Deprecated in PHP 8.4: Parameter #2 $form_state (Drupal\Core\Form\FormStateInterface) is implicitly nullable
         via default value null.
  121    No error to ignore is reported on line 121.
 ------ --------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------
  Line   src/Plugin/field_group/FieldGroupFormatter/Details.php
 ------ ---------------------------------------------------------------------------------------------------------
  124    Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0
         required.
 ------ ---------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------
  Line   src/Plugin/field_group/FieldGroupFormatter/Fieldset.php
 ------ ---------------------------------------------------------------------------------------------------------
  116    Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0
         required.
 ------ ---------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------
  Line   src/Plugin/field_group/FieldGroupFormatter/HtmlElement.php
 ------ ---------------------------------------------------------------------------------------------------------
  253    Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0
         required.
 ------ ---------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------
  Line   src/Plugin/field_group/FieldGroupFormatter/Tab.php
 ------ ---------------------------------------------------------------------------------------------------------
  123    Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0
         required.
 ------ ---------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------
  Line   tests/modules/field_group_test/field_group_test.module
 ------ --------------------------------------------------------------------------------------------------------------
  20     Deprecated in PHP 8.4: Parameter #4 $items (Drupal\Core\Field\FieldItemListInterface) is implicitly nullable
         via default value null.
 ------ --------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------
  Line   tests/src/FunctionalJavascript/HorizontalTabsLabelsTest.php
 ------ -------------------------------------------------------------------------------------------------------
  119    @dataProvider providerTestHorizontalTabsLabels related method must be static in PHPUnit 10 and newer.
 ------ -------------------------------------------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#24 3504453-field_group-MR-98--24.patch6.62 KBkiseleva.t

Issue fork field_group-3504453

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

nidhish’s picture

nidhish commented
Assigned: Unassigned » nidhish
lrwebks’s picture

lrwebks commented
Assigned: nidhish » lrwebks
Status: Active » Needs work

lrwebks opened merge request !95

nils.destoop made their first commit to this issue’s fork.

beloglazov91 made their first commit to this issue’s fork.

beloglazov91 opened merge request !98

liam morland made their first commit to this issue’s fork.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
Issue tags: +PHP 8.4

Tests are passing for 4.x. They are failing for 8.x-3.x, but they are failing on the dev branch too. The merge request here fixes phpcs on that branch.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

phpunit now passes on both branches.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: lrwebks » Unassigned
Status: Needs review » Reviewed & tested by the community

@nils.destoop guess the issue can be set fixed?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This has been done on 4.x. Will this also be done on 8.x-3.x?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

@liam morland I just tried a cherry-pick. If someone reviews it and confirms it works, I'm willing to merge it into 8.x-3.x.

For now, I'm setting this fixed.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks. The cherry-pick looks good.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 4.x-dev » 8.x-3.x-dev
Status: Fixed » Needs review

anybody changed the visibility of the branch 8.x-3.x to hidden.

anybody changed the visibility of the branch 4.x to hidden.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Sorry, here's the MR to review: https://git.drupalcode.org/project/field_group/-/merge_requests/100
We could also merge MR!98, but I don't have time to review and decide currently.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Looks good

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@liam morland so which one should I merge?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Merge !100, then !101, then !102. Then you can close !98.

steinmb’s picture

steinmb commented

Is there anything that is holding this back?

kiseleva.t’s picture

kiseleva.t commented
StatusFileSize
new 3504453-field_group-MR-98--24.patch6.62 KB

Exported MR into patch to use in composer.

  • grevil committed 3f33b1b2 on 8.x-3.x authored by anybody 
    Part of Issue #3504453 by liam morland, lrwebks, nils.destoop, anybody,...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

grevil closed merge request !98

grevil’s picture

grevil commented

All done. !102 is not yet merged, since the tests fail again after rebase. See #3509697: Make tests pass on 8.x-3.x.

!102 will be the last commit going into 3.x. Any further work will be done in 4.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.