Closed (fixed)
Project:
Webform
Version:
6.3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Oct 2024 at 19:04 UTC
Updated:
24 Dec 2024 at 17:04 UTC
Jump to comment: Most recent
Problem/Motivation
Tests no longer pass. They did pass in the merge request for the latest commit, 4624076 (Drupal 11 compatibility). I suspect that the failure is because of changes made in #3463894: Update templates so 11.0 is the default/current branch.
Proposed resolution
Make tests pass. This may just be adjusting the testing config.
Remaining tasks
Figure out what is wrong. Implement.
User interface changes
None.
API changes
None.
Data model changes
None.
Issue fork webform-3481554
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #5
liam morlandThe easiest solution may be to pin the version of the template. It could be pinned to the latest version of template 1.5.x.
Comment #6
pfrenssenPinning the version would be a workable temporary solution, but we would then still have to update the template later.
It looks like the failures are just because in the test fixes introduced in #3465838: Drupal 11 compatibility fixes for webform we are not making a distinction between Drupal 11.0 and 11.1. Now tests are running on Drupal 11.0.5, but some of the tests are checking features introduced in 11.1 (like #3347343: Add Views EntityReference filter to support better UX for exposed filters and #3466529: Use easily recognizable date format)
I'm hoping that fixing this will turn the pipelines green.
Comment #7
pfrenssenYay green!
Comment #12
liam morlandThanks very much!
Comment #13
liam morlandTests were passing but now they are failing again. The "Previous major" tests are passing but not the current version tests.
Comment #14
liam morlandThe test failures are related to
ckeditorso it is likely that they would be fixed by completing #3479443: Remove legacy ckeditor from codebase..Comment #15
kul.pratap commented@liam morland The following issue is in RTBC. Please review and merge it so we can proceed with the current issue.
#3479443: Remove legacy ckeditor from codebase.
Comment #16
liam morlandTests are passing again.
Comment #17
liam morlandTest are not passing again.
Comment #20
jrockowitz commentedLet's see if we can get the tests to pass and potentially tag a beta release for Drupal CMS.
Comment #21
liam morlandYes, I was thinking it was time to tag an alpha once tests pass.
If this test was converted to XPath, checking for the needed elements and attributes instead of a specific string, it would probably work without the need for
version_compare().Comment #22
jrockowitz commentedAs soon as this test passes and I merge the change, tagging an alpha would be great. For now, I want to avoid any code refactoring.
For Drupal CMS, tagging a beta by 12/8 would be ideal. I will review tickets to see if anything is required for a beta release.
Comment #23
liam morlandI switched the test to XPath and now the one test passes on all versions.
I initially included a test for the contents of the
data-drupal-statesattribute, but that didn't work. I suspect we don't need to test that anyway since it is a Drupal internal thing.Unless you disagree with this approach, I will merge and tag an alpha today. If no release-blockers appear in two weeks, we can have a beta on December 6.
Comment #24
jrockowitz commentedLet's merge it and tag an alpha release.
Comment #27
liam morland6.3.0-alpha1 released.
Comment #29
liam morlandTests are failing again.
Comment #33
liam morland