Problem/Motivation
Currently we rely on SCSS to wrap ckeditor 5 stylesheets in .ck-content. This is cumbersome as it requires wrapping base and element styles in a mixin, then immediately calling that mixin.
There are also a couple existing bugs related to this approach:
- The wysiwyg stylesheet outputs unprefixed styles along with the prefixed styles. Which will cause rendering issues in admin themes.
:rootselectors get prefixed with.ck-contentwhich results in an invalid selector.
Solution
Install and configure postcss-prefixwrap
Issue fork prototype-3473791
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
pixelwhip commentedComment #4
pixelwhip commentedI've added the initial configuration for the plugin and updated a couple files as a proof of concept.
Marking this postponed until 3469567 is resolved to avoid the inevitable merge conflicts.
Comment #5
jldust commentedWe have now pulled in the component folder update, this needs to be rebased off the main 5.x branch and then it should be ready for review.
Comment #8
pixelwhip commentedThis is ready for review. It has been rebased onto the latest 5.x branch.
Comment #9
philip_stier commentedThis looks great! Thanks for the much needed changed John!
Comment #11
jldust commentedThanks all! This has been merged and will be included in the next tagged release.
Comment #12
jldust commented