Problem/Motivation

Currently we rely on SCSS to wrap ckeditor 5 stylesheets in .ck-content. This is cumbersome as it requires wrapping base and element styles in a mixin, then immediately calling that mixin.

There are also a couple existing bugs related to this approach:

  1. The wysiwyg stylesheet outputs unprefixed styles along with the prefixed styles. Which will cause rendering issues in admin themes.
  2. :root selectors get prefixed with .ck-content which results in an invalid selector.

Solution

Install and configure postcss-prefixwrap

Issue fork prototype-3473791

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pixelwhip created an issue. See original summary.

pixelwhip’s picture

Issue summary: View changes
pixelwhip’s picture

Status: Active » Postponed
Related issues: +#3469567: Component Folder Structure

I've added the initial configuration for the plugin and updated a couple files as a proof of concept.

Marking this postponed until 3469567 is resolved to avoid the inevitable merge conflicts.

jldust’s picture

Status: Postponed » Needs work

We have now pulled in the component folder update, this needs to be rebased off the main 5.x branch and then it should be ready for review.

pixelwhip’s picture

Status: Needs work » Needs review

This is ready for review. It has been rebased onto the latest 5.x branch.

philip_stier’s picture

This looks great! Thanks for the much needed changed John!

  • jldust committed f195dfc9 on 5.x authored by pixelwhip
    Issue #3473791 by pixelwhip, jldust, philip_stier: Simplify WYSIWIG...
jldust’s picture

Status: Needs review » Fixed

Thanks all! This has been merged and will be included in the next tagged release.

jldust’s picture

Status: Fixed » Closed (fixed)