Problem/Motivation

The Delete action is hidden out in most entity editing after
#3356717: Move Action buttons to sticky header

Steps to reproduce

When editing entities
  Then the "Delete", or "Cancel account" is not showing out for editors

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ UX/UI designer responsibilities
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0, varbase_core-10.0.27, varbase_core-10.0.28

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

Kept the "delete" action button in the more actions with Default Gin provided behaviour API for sticky form actions
Reverted any old direction of change for that.

  • Updating the Automated Functional Acceptance Testing for Varbase for all Entity Types
  • Documentation update will be needed

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3459779: Reverted: moving the delete action button as a gin action item and kept in the more actions with Default Gin provided behaviour API for sticky form actions

Comments

Rajab Natshah created an issue. See original summary.

rajab natshah’s picture

  • Rajab Natshah committed 92187cb2 on 10.0.x
    Issue #3459779: Fix regression for the Action buttons in sticky header,...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-10.0.0, +varbase_core-10.0.27
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Fixed » Needs work

After a review with the product owner and Razem.
The direction went to follow with the new change by the Gin Admin theme on #3356717: Move Action buttons to sticky header

rajab natshah’s picture

  • Revert the change of code for the "unlock" and "delete" buttons
  • Update the Automated Functional Acceptance Testing for all entity types (users, blocks, paragraphs)
rajab natshah’s picture

Title: Fix regression for the Action buttons in sticky header, which Gin provided a new API for sticky form actions » Revert: Fix regression for the Action buttons in sticky header, which Gin provided a new API for sticky form actions
rajab natshah’s picture

Title: Revert: Fix regression for the Action buttons in sticky header, which Gin provided a new API for sticky form actions » Revert: moving delete to as a gin action item and keeping Default Gin provided behaviour a new API for sticky form actions
rajab natshah’s picture

Title: Revert: moving delete to as a gin action item and keeping Default Gin provided behaviour a new API for sticky form actions » Revert: moving delete as a gin action item and keeping in the more actions with Default Gin provided behaviour API for sticky form actions

  • Rajab Natshah committed bb2f5721 on 10.0.x
    Issue #3459779: Revert: moving delete as a gin action item and keeping...
rajab natshah’s picture

Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +varbase_core-10.0.28
rajab natshah’s picture

Title: Revert: moving delete as a gin action item and keeping in the more actions with Default Gin provided behaviour API for sticky form actions » Revert: moving the delete action button as a gin action item and kept in the more actions with Default Gin provided behaviour API for sticky form actions
Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.