Problem/Motivation

Varbase had #3436163: Move the Save as Draft moderation state element next to preview and Save in the Edit content with workflow
But after #3356717: Move Action buttons to sticky header

Steps to reproduce

 Given I am a logged in user with the "Editor" user
    When I go to "/node/add/page"
    And wait
    And I fill in "Test Basic page" for "Title"
    And I fill in the rich text editor field "Body" with "Test Basic page body"
    And I select "published" from "edit-moderation-state-0-state--2--gin-edit-form"

An extra step to click on the

Proposed resolution

  • Integrate more with latest new Action button API in the Gin Admin theme.
  • Enable sticky action buttons Beta New
  • Displays all actions of the form in the sticky header.
  • Keep the fix for the moderation status only

The sticky action buttons API allows for :

  • Register form ids to apply Gin’s sticky action buttons.
  • Alter the registered form ids to enable or disable Gin’s sticky form actions.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0, varbase_workflow-3.0.6, varbase_workflow-3.0.7, varbase_workflow-3.0.8

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

When creating a new content
When creating a new content

When Editing an existing content
When Editing an  existing content 1

When Editing an existing content 2

When Editing an existing content 3

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3459076: Fixed regression for the moderation state element in Action buttons in sticky header, which Gin provided a new API for sticky form actions

Comments

Rajab Natshah created an issue. See original summary.

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Project: Varbase Core » Varbase Workflow
Version: 10.0.x-dev » 3.0.x-dev
rajab natshah’s picture

  • Rajab Natshah committed 7c88c39e on 3.0.x
    Issue #3459076: Fix regression for the Action buttons in sticky header,...
rajab natshah’s picture

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed eb090557 on 3.0.x
    Issue #3459076: Fix regression for the Action buttons in sticky header,...
rajab natshah’s picture

Gin Admin Theme 8.x-3.0-rc13 had a new release on: 8 Jul 2024 by: saschaeggi
https://www.drupal.org/project/gin/releases/8.x-3.0-rc13


Thank you, Sascha!
rajab natshah’s picture

Followed up with more fixes on this issue, which effected all create new or edit contents, with draft or publish moderation status

rajab natshah’s picture

Issue summary: View changes
Issue tags: +varbase_workflow-3.0.7
rajab natshah’s picture

Status: Fixed » Needs work

After a review with the product owner and Razem.
The direction went to follow with the new change by the Gin Admin theme on #3356717: Move Action buttons to sticky header

rajab natshah’s picture

  • Keep the fix for the moderation status
  • Revert the change of code for the "unlock" and "delete" buttons
  • Update the Automated Functional Acceptance Testing for Varbase
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Title: Fix regression for the Action buttons in sticky header, which Gin provided a new API for sticky form actions » Fix regression for the moderation state element in Action buttons in sticky header, which Gin provided a new API for sticky form actions
rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed 2a3bfd93 on 3.0.x
    Issue #3459076: Fix regression for the moderation state element in...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Needs work » Active
rajab natshah’s picture

Status: Active » Needs review
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
Issue tags: +varbase_workflow-3.0.8
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.