Problem/Motivation

Upgrading Drupal core to 10.3 breaks the CKEditor with the following error in the console: TypeError: e.Model is not a constructor. I think it's very similar to #3452570: CKEditor 5 41.3.1 (Drupal 10.3 beta) breaking change. If you disable the ckeditor5_template module, the error disappears and the CKEditor works again.

Steps to reproduce

Install Drupal core version 10.3 and ckeditor5_template version 1.0.5.

Proposed resolution

I think the same as the solution in #3452570: CKEditor 5 41.3.1 (Drupal 10.3 beta) breaking change.

Comments

Ewout Goosmann created an issue. See original summary.

vincent.hoehn’s picture

vincent.hoehn
Primary language German
Location Dresden, Germany
commented
Assigned: Unassigned » vincent.hoehn

Hi Ewout,

thanks for reporting the issue. I can reproduce the error. We will look into it and solve it as soon as possible.

BR
Vincent

vincent.hoehn’s picture

vincent.hoehn
Primary language German
Location Dresden, Germany
commented
Status: Active » Fixed
Related issues: +#3449851: Replace LogicException with trigger_error in LangcodeRequiredIfTranslatableValues constraint

Hello again, I have resolved the issue, thank you for your help!

There is another issue in drupal core. It is not possible to save a text format. This patch needs to be applied.
I hope this problem will be fixed in core soon.

Can you please install the dev release, apply the patch and confirm that this resolves the issue?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.5 » 1.0.x-dev
Issue summary: View changes
mizage@gmail.com’s picture

mizage@gmail.com commented

I can confirm that the dev version with the core patch resolves the issue for me.

rex.barkdoll’s picture

rex.barkdoll commented

I'm also confirming that applying the core patch to drupal/core and using the Dev version of this module fixes the issue. Also had to hard refresh (shift+ctrl+R) my browser once I was back to editing to clear my browser cache. After that, everything was good.

vincent.hoehn’s picture

vincent.hoehn
Primary language German
Location Dresden, Germany
commented
Version: 1.0.x-dev » 1.0.6
Assigned: vincent.hoehn » Unassigned

Hello guys. Thank you for confirming the fix. A new stable release is now available.

  • vincent.hoehn committed 7be34d41 on 1.0.x 
    git commit -m 'Issue #3456952: Updating core to 10.3 breaks CKEditor'
vincent.hoehn’s picture

vincent.hoehn
Primary language German
Location Dresden, Germany
commented
Version: 1.0.6 » 1.0.8

Another side effect was an incorrect config type in the schema.yml file.
This has been fixed in the new release and a patch is no longer necessary. Many thanks

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.8 » 1.0.x-dev

Bugs are supposed to be against the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.