Replace LogicException with trigger_error in LangcodeRequiredIfTranslatableValues constraint

I can confirm I'm having this error twice now (on two different sites), and it doesn't allow me to change any text format configuration that has CKEditor5 anymore.

Drupal 10.2.6 doesn't have this. This doesn't come out of the box but after playing around with CKEditor toolbar or removing a text format.

error trace

Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateConstraints() (Line: 154)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateNode() (Line: 164)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateNode() (Line: 164)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateNode() (Line: 164)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateNode() (Line: 106)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validate() (Line: 93)
Drupal\Core\TypedData\Validation\RecursiveValidator->validate() (Line: 132)
Drupal\Core\TypedData\TypedData->validate() (Line: 234)
Drupal\ckeditor5\Plugin\Editor\CKEditor5::validatePair() (Line: 680)
Drupal\ckeditor5\Plugin\Editor\CKEditor5->validateConfigurationForm() (Line: 207)
editor_form_filter_admin_format_validate()
call_user_func_array() (Line: 82)
Drupal\Core\Form\FormValidator->executeValidateHandlers() (Line: 274)
Drupal\Core\Form\FormValidator->doValidateForm() (Line: 118)
Drupal\Core\Form\FormValidator->validateForm() (Line: 593)
Drupal\Core\Form\FormBuilder->processForm() (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 737)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Confirmed, I have the same problem after updating to Drupal 10.3.0-beta1
Exactly the same errors mentioned above.

I updated to Drupal 10.3.0 and the problem still persists which is very irritating.
Is there a chance for a quick solution so that I can edit the text format settings?

Yes. Performing a git bisect on a checkout of Drupal Core between a good and bad release tag will quickly find the issue that introduced the regression.

LangcodeRequiredIfTranslatableValues is new in 10.3, added in #3427564: Require `langcode: …` only for simple config that contains translatable values.

This merge request changes the LogicException to a E_USER_DEPRECATED error. This allows text formats to be saved. This may be a good short-term fix.

This patch represents the current state of the merge request.

in my case I was getting the same error message after adding ckeditor5_template button on the toolbar.
After applied the patch in #13, the editor doesn't show up/blank at node edit page.
this error did't occur with drupal 10.2.7

Drupal 10.3.0
php 8.4
admin theme: Gin
fix #13 worked fine after clearing cache, Ckeditor 5 bar is correct for all options (Full, Office, etc.)

I hope the patch will be included in the next Drupal 10.3 patch

Thank you very much for help.

I can confirm that the patch in #13 fixes the issue. I hope it will be included in core soon!

Change should be turned to an MR.

Issue summary is incomplete so that should be updated using the standard template.

Have not reviewed patch

The change already is a MR; see #10. #13 is there to allow patching from Composer.

This was intentionally targeting Drupal 10.3 because this is a quick solution to fix broken sites and people will probably want some other fix in 11.x.

Issue summary updated.

it's missed the 10.3 boat unfortunately

I was anticipating this would deploy with 10.3.1 to fix sites broken by 10.3.0.

Looking at the steps

On Drupal 10.3, edit and then save a text format

this doesn't cause any issue, would imagine a test failure would of happened if so. So there needs to be determined what the issue is and have coverage for that.

But this missed 10.3 and can't be removed in 11 as that's out now too. So if anything it would be 10.4 and removed in 12 if it gets added.

MR should be made for 11.x (main branch)

Did you look at the patch? I expect that if this patch were proposed to be merged into Drupal 11 or 12, that would be refused on the basis that the LogicException is correct and that the bug is buried elsewhere in the code. That is probably true. What we need now is a fix for the sites that were broken by the 10.3.0 upgrade.

The issue only appears when saving a text format that uses CKEditor. It is possible that there is some other condition also required to trigger the problem. Several people are having this problem and the fix works for them.

Okay I'm going to leave this issue, I don't believe its going to be merged but will leave in review for others

Do you have another suggestion for how to fix this?

If this cannot be quickly fixed, there should be a warning message to caution people against upgrading to Drupal 10.3.

I mean the exception is very vague, I imagine the scenario is that some config got in after #3427564: Require `langcode: …` only for simple config that contains translatable values so would be more useful to say what config is causing the issue. Then you could go and fix the file.

But that's an untested theory

I didn't mean to switch the status.

Opened this yesterday too as I saw it with configuration inspector.

We are not using config_inspector and yet we see this error. So, my hunch is that the other issue should be closed as a duplicate of this. Perhaps the error message should point out what config is wrong, as you suggest in the other issue.

I can confirm that the patch in #13 fixes the issue for drupal core 10.3

Patch #13 works in Drupal 10.3. (I don't use config_inspector either.)

Same problem with 10.3.0
Cannot modify existing text format

@dadderley If you still have a problem in 10.3, then your text format is using an invalid CKEditor plugin, or maybe something else is wrong in the text format's configuration. I had the same problem, too, prior to discovering that.

You need to discover why an error is being thrown. Even if the Exception is not thrown after applying the patch, there is still an error being triggered, and it will again throw an Exception in Drupal 11.

The title becomes the commit message and an error message is not very useful when going through the logs. Can someone change this to what is being fixed?

How's this?

@solideogloria
I have a few sites that have been updated to D 10.3.0

This is happening in sites that use this plugin
Obfuscate Email
https://www.drupal.org/project/obfuscate_email

This is a new issue with the plugin that is related to the D 10.3.0 upgrade
https://www.drupal.org/project/obfuscate_email/issues/3457393

I cannot uninstall the plugin because a text format requires it.
I cannot disable the plugin because it throws this error when trying to save the text format.

Error message
'click' is not a supported key.
'click_label' is not a supported key.

Interestingly enough on one of the updated sites where I have the Obfuscate Email plugin installed, I don't get the error message, just a WSOD when I try to save the text format.

Is this helpful information?

Edit
There has been a new release of the Obfuscate Email module which seems to have cleared up the issue that I mentioned.

If you still have the issue, try setting a breakpoint in the code where the error is thrown from. You might have another plugin throwing errors.

You could also try disabling all non-core modules and see if that fixes it, and try to figure out if it's related to a certain module.

@solideogloria
I found the offending Ckeditor plugin.
Thanks again.

See this issue

Symfony\Component\Validator\Exception\LogicException: The LangcodeRequiredIfTranslatableValues constraint can only operate on the root object being validated.
https://www.drupal.org/project/ckeditor_indentblock/issues/3457094

This error indicates that type: config_object has been added in an incorrect place in the schema. I agree that the friendly thing to do here is to emit a deprecation in 10.x and leave a break in 11.x as this is not a great thing. The config that has config_object placed at the wrong level will be invalid according to its schema.

I've added some comments to address to the MR.

Not sure what's best to do about the change record here, should we add a new CR alongside the ones that were already added for #3427629: `langcode: …` is now required for config objects that contain translatable values?

I think deprecation in 10.3 to exception in 11.x is OK given the config schema was invalid in these modules already.

Made an attempt at a CR https://www.drupal.org/node/3459863

I've fixed the 10.3.x MR and I've provided an 11.x that improves the exception message so it is less cryptic. The deprecation message for 10.x is also explicit now too.

Had to run the tests locally since can't run the test-only feature here

Failed asserting that exception message 'The LangcodeRequiredIfTranslatableValues constraint can only operate on the root object being validated.' contains 'The LangcodeRequiredIfTranslatableValues constraint is applied to 'config_test.foo::broken_langcode_required'. This constraint can only operate on the root object being validated.'.

Love the updated text, super helpful

Committed/pushed to 11.x, 11.0.x, 10.4.x and 10.3.x respectively, thanks!

I seem to have invented a patch release in my head.