Problem/Motivation

The Drupal 10.3 beta CKEditor 5 41.2.0 to 41.3.1 update introduced a breaking change. CKEditor has renamed an export in ckeditor5/src/ui from Model to ViewModel and this completely breaks the icon picker.

Steps to reproduce

Either update to Drupal 10.3 beta, or update to CKEditor 5 41.3.1 on an existing Drupal installation.

Proposed resolution

Update composer.json to use CKEditor 5 41.3.1 and rename the Model to ViewModel as necessary.

This fix may break backward-compatibility with Drupal 10.2 and earlier. Shim available for Drupal 10.2 and earlier.

Issue fork ckeditor5_icons-3452570

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

timurtripp created an issue. See original summary.

timurtripp opened merge request !7

  • timurtripp committed 03fc00de on 1.x 
    Issue #3452570: Adds compatibility with CKEditor 5 41.3.1 (Drupal 10.3)

  • timurtripp committed 981ebd8e on 1.x 
    Issue #3452570: Adds compatibility with CKEditor 5 41.3.1 (Drupal 10.3...
timurtripp’s picture

timurtripp commented
Status: Needs work » Needs review
timurtripp’s picture

timurtripp commented

Fix pushed to dev branch, working on my end with both 41.2.0 and 41.3.1 but needs further review.

timurtripp’s picture

timurtripp commented
Issue summary: View changes
lefteous’s picture

lefteous commented

Tested the changes made in the newest 1.x-dev branch.
In the D10.2.6 version the shim seems to be working correctly. No problems thrown in the console.
In the D10.3 beta the picker loads quickly instead of being stuck in a forever load.

timurtripp’s picture

timurtripp commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.