Problem/Motivation

At present, the dropdown menu displays a maximum of two levels regardless of the assigned depth.

Steps to reproduce

  • Enable dropdown for any menu.
  • Assign a depth greater than 2

Proposed resolution

By making the dropdown component recursive and adding a CSS class for identification.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.1, varbase_components-2.0.4

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

CommentFileSizeAuthor
#2 fix_dropdown_menu_limited_to_only_two_levels-3456935-2.patch3.52 KBahmad khader

Issue fork varbase_components-3456935

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ahmad Khader created an issue. See original summary.

ahmad khader’s picture

ahmad khader commented
Status: Active » Needs review
StatusFileSize
new fix_dropdown_menu_limited_to_only_two_levels-3456935-2.patch3.52 KB

Ahmad Khader opened merge request !19

rajab natshah’s picture

rajab natshah
he/him
commented

Facing the following issue

Uncaught TypeError: Popper__namespace.createPopper is not a function
    at Dropdown._createPopper (dropdown.js?she4rn:220:40)
    at Dropdown.show (dropdown.js?she4rn:137:12)
    at Dropdown.toggle (dropdown.js?she4rn:124:51)
    at HTMLAnchorElement.<anonymous> (dropdown.js?she4rn:390:40)
    at HTMLDocument.handler (event-handler.js?she4rn:75:21)

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Issue tags: +varbase-10.0.1, +varbase_components-2.0.4
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released varbase_components-2.0.4

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released varbase-10.0.1

rajab natshah’s picture

rajab natshah
he/him
commented

Facing a follow up issue #3469222: Fix Popper.js Error When Adding Navbar Dropdown in Vartheme BS5

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.