Problem/Motivation
Image and pagination are broken cause of Attribute property.
Steps to reproduce
- Run storybook
- Check image field
Proposed resolution
- Change
"control": "object",to"control": "Drupal\\Core\\Template\\Attribute",only for attributes in all.stories.jsonfiles
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release varbase-10.0.0, varbase_components-2.0.3
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Issue #3456931 by Ahmad Khader: Fixed not working Attributes object in storybook
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Screenshot from 2024-06-26 01-48-31.png | 439.42 KB | ahmad khader |
| #5 | Screenshot from 2024-06-26 01-47-42.png | 237.86 KB | ahmad khader |
| #2 | fix_attributes_object_not_working_in_storybook-3456925-2.patch | 17.22 KB | ahmad khader |
Comments
Comment #2
ahmad khader commentedComment #3
ahmad khader commentedComment #4
rajab natshahAre you facing this after the update to Drupal ~10.3.0 ?
Comment #5
ahmad khader commentedNo, issue appeared before and after the update to Drupal ~10.3.0
After the fix
Comment #7
rajab natshahChange
"control": "object",to"control": "Drupal\\Core\\Template\\Attribute",only for attributes in all.stories.jsonfilesComment #8
rajab natshahComment #9
rajab natshah✅ Released varbase_components-2.0.3
Comment #10
rajab natshahComment #11
rajab natshah✅ Released varbase-10.0.0