Get large thumbnail for Vimeo and Youtube in media oEmbed.

+1

#2 worked! Tested on Drupal 11.0-dev, PHP 8.3.

Good catch and a must-have fix.

By default, it pulls low resolution (480 × 360 pixels) and stores as original style.
After applying the patch, it pulls high resolution (1280 × 720 pixels) and stores as original style.

There is a patch here that failed testing. Please fix that and merge requests are preferred.

Also: It isn't clear what the screenshots in comment #6 are representing as supporting this issue being ready to commit.

Fixes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

The patch also worked on my Drupal 10.3.2 (with Thunder distro).

I haven't done any testing, just added the patch in composer.json on a demo I'm working on.

Hi,

I created an MR Please review I tested the test cases, and now the test cases are working fine.

I would greatly appreciate your suggestions for improvement. Please let me know.

Thank you!!

Left comments in MR.

Hi @smustgrave ,

Thanks for the review.

I updated the MR. The test coverage for the provider's name is already covered.
Path: core/modules/media/tests/src/Functional/ResourceFetcherTest.php

Please let me know for other concerns. I am happy to take suggestions.

Thank you!!

Test coverage should be expanded for additional changes.

While it works and gets the maxresdefault image for most YouTube Videos, it does not work every time. There is a chance that a video does not provide a maxresdefault image, just the default hqdefault. I guess that's something to do with the video size.

I added a check that the maxresdefault image is only used, when available. Otherwise, it will just return a 404.

Before the change, this would leave media entities without a thumbnail at all.

Hello,

I had the same problème on Drupal 10.3.5

Trying the patch in #2 didn't solve the problem because the http 404 error request was overriding the response.

So I did this patch that's working for my use case, maybe it needs more testing

There are a few issues with the patch in #19:

1. In the new method doVimeoRequest, the TransferException is not defined and needs to be imported.
2. the import "use GuzzleHttp\Client" is never used.
3. The fallback for Youtube should be uncommented:
   

         catch (RequestException $e) {
           // Use default thumbnail.
           //$data['thumbnail_url'] = str_replace('maxresdefault', 'hqdefault', $data['thumbnail_url']);
         }
   

Pushed some fixes for better error handling. This is now working for me when Vimeo does not have a high resolution option.
Thinking about this more, I feel like it could be better handled in \Drupal\media\Plugin\media\Source\OEmbed::getLocalThumbnailUri() so that the high resolution image is only requested once and then the local file is created. Currently, the fixes in this issue would causes the high resolution images to be request every time the resource cache is rebuilt. This seems a bit excessive to me.

Hi I have some errors that break the site when a Vimeo video is removed. So I have created a patch from Drupal 10 (Tested on 10.4.1) with Drupal 11 solution. If anyone have the same problem, try to use this patch and check if it solve the error.

If you want to replicate the error I had, just create a remote video with a fake vimeo url like this one: https://vimeo.com/3453453453453

Shouldn't the bulk of this code live within the provider rather than here?

Maybe ResourceFetcherInterface should ask the ProviderRepositoryInterface "Here's the data from the oEmbed call. Is there a URL for a higher-quality version of the thumbnail?" and it responds with a URL. Then ResourceFetcherInterface then tests to see if it can get an image from that URL, otherwise falls back to the original.

With this approach ResourceFetcherInterface doesn't need to know about how each provider's API works, and the providers don't have to replicate the work of testing to see if the higher-quality version exists.

Fix oembed & get max thumbnail size for vimeo & youtube.

Better patch for vimeo because some large thumbnails are too small.

I couldn't apply the patches 28-30, but the latest MR applied. I'm assuming I need to play about with CSS on the IFRAME to get the larger thumbnail to render in a suitable size, rather than some magic happening out of the box.

Thumbnail looks great.

Updated patch with latest 11.3.8 release.