Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new544 bytes
new4.25 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-137198

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.10
  3. palantirnet/drupal-rector: 0.20.1

ankitv18 made their first commit to this issue’s fork.

anfor made their first commit to this issue’s fork.

anfor’s picture

Issue summary: View changes
Status: Needs review » Needs work

Issue version should be bump to 3.0.x, right ?
And the gitlab CI variable OPT_IN_TEST_PREVIOUS_MAJOR should be deleted, to reset to default value (which is 0) ?

maunm’s picture

StatusFileSize
new16.31 KB

Adding a patch with current D11 compatibility changes until now.

maunm’s picture

StatusFileSize
new17.7 KB

Previous patch had an issue to apply. Updating the patch.

grevil’s picture

@maunm there is an open MR, no need for patches!

grevil’s picture

Assigned: Unassigned » grevil
grevil’s picture

Version: 8.x-2.x-dev » 3.0.x-dev
grevil’s picture

Assigned: grevil » Unassigned
Status: Needs work » Needs review

All green now! Please review!

Incorrect commit message my bad:

Remove previous MAJOR* opt-in
ankitv18’s picture

@grevil I've restore the Previous Major pipeline as we haven't dropped D9 support.
If maintainer asked to drop D9 then please do revert this commit #607b6681.

grevil’s picture

Status: Needs review » Needs work

@ankitv18 ok! Setting back to "Needs work" as previous major fails.

@ankitv18 could you take a look? Quite baffled, why they fail.

ankitv18’s picture

Status: Needs work » Needs review

@grevil Just done some nitpick and now pipelines are clean.
Please review MR!36

grevil’s picture

Status: Needs review » Reviewed & tested by the community

Ahh, "CORE_PREVIOUS_PHP_MIN" nice one! 👍

LGTM! Thanks!

eswiderski’s picture

#8 failing for me

anfor’s picture

grevil’s picture

@eswiderski please use the MR instead, or create a static patch from it if needed: https://git.drupalcode.org/project/menu_item_extras/-/merge_requests/36....

ankitv18’s picture

+1 as per suggested by @grevil instead of .diff file path you can replace with .patch of MR url https://git.drupalcode.org/project/menu_item_extras/-/merge_requests/36....

grevil’s picture

Status: Reviewed & tested by the community » Needs review

Alright, did some final adjustments, please review!

voleger’s picture

Version: 3.0.x-dev » 3.1.x-dev
Status: Needs review » Reviewed & tested by the community

Looks good

  • voleger committed 3b64d96e on 3.1.x authored by ankitv18
    Issue #3438486: Automated Drupal 11 compatibility fixes for...
voleger’s picture

Status: Reviewed & tested by the community » Fixed

Fixed, thanks. I opened a separate minor version branch as we changed the requirements for this module.

grevil’s picture

Thanks for taking the time! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.