Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#2 vlsuite.1.1.3.upgrade_status.post_rector.txt52.52 KBproject update bot
#2 vlsuite.1.1.3.rector.patch1.31 KBproject update bot

Issue fork vlsuite-3435575

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new vlsuite.1.1.3.rector.patch1.31 KB
new vlsuite.1.1.3.upgrade_status.post_rector.txt52.52 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !41

crzdev’s picture

crzdev commented
Issue summary: View changes
Status: Needs review » Active
crzdev’s picture

crzdev commented
Status: Active » Needs work

Core 11 compatibility key points:
1. Dependencies version upgrade:

    "drupal/entity": "^1.4",
    "drupal/layout_builder_at": "^2.13",
    "drupal/layout_builder_operation_link": "^2.1",
    "drupal/layout_builder_restrictions": "^2.17",
    "drupal/media_library_form_element": "^2.0",
    "drupal/media_responsive_thumbnail": "^1.5",
    "drupal/section_library": "^1.1"

2. Patches:

"drupal/core": {
        "3207875 - \"Unsaved changes\" message incorrectly appears on layout builder": "https://www.drupal.org/files/issues/2021-08-13/3207875--20.patch",
        "3030154 - layout_builder__layout_section column hitting database limit": "https://www.drupal.org/files/issues/2023-04-06/3030154-62_0.patch",
        "3045509 - EntityFieldManager::getFieldMap() doesn't show bundle fields": "https://git.drupalcode.org/issue/drupal-3045509/-/commit/2d55b4ff75f2f7358ff765f3ec63591e45ca6f15.patch"
      },
      "drupal/section_library": {
        "3217647: Adding stuff to library doesn't close dialog if dialog opens in popup": "https://www.drupal.org/files/issues/2021-06-07/section_library.3217647.close-dialog.2.patch"
      }


3. Main VLSuite module & all others inside

crzdev opened merge request !46

crzdev’s picture

crzdev commented
Version: 1.1.3 » 1.1.x-dev
crzdev’s picture

crzdev commented

Created 2.x branch in origin that will be compatible with core 11 & it will drop compatibility with already end of life core 9 (changed MR to point that branch)
Related:
Drupal 9 is end of life - PSA-2023-11-01: https://www.drupal.org/psa-2023-11-01
Drupal.org release version numbers allow semantic versioning: https://www.drupal.org/node/3108648

crzdev’s picture

crzdev commented
Version: 1.1.x-dev » 2.x-dev

  • crzdev committed 8a181f8d on 2.x 
    Issue #3435575: Automated Drupal 11 compatibility fixes for vlsuite
crzdev’s picture

crzdev commented
Related issues: +#3431569: Automated Drupal 11 compatibility fixes for layout_builder_at, +#3469293: RenderElement is deprecated in drupal:10.3.0 and is removed from drupal:12.0.0, +#3431911: Automated Drupal 11 compatibility fixes for media_responsive_thumbnail, +#3434418: Automated Drupal 11 compatibility fixes for section_library

Added modules dependencies directly as related issues for core 11 compatibility.

Also related:
https://endoflife.date/drupal
https://www.drupal.org/about/core/policies/core-release-cycles/schedule

crzdev’s picture

crzdev commented

Manually checked 2.x-dev into existing installation, basis review with no regressions detected (core 10, 11 still unable to resolve composer dependencies, see related issues, "composer require 'drupal/vlsuite:2.x-dev@dev' 'drupal/media_library_form_element:2.0.6 as 2.1.0' -W").

Waiting some advance into related modules compatibility and/or core release schedule.

crzdev’s picture

crzdev commented

To use with core 11 using composer:
Make sure vcs of compatible core 11 module dependencies are defined before "https://packages.drupal.org/8"

  "repositories": [
        {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/layout_builder_at-3431569.git"
        },
        {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/media_responsive_thumbnail-3431911.git"
        },
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        }
    ],

Then:

composer require "drupal/layout_builder_at:dev-project-update-bot-only#1711072acdd1316d2648372557bf4273a9352e66 as 2.x-dev"
composer require "drupal/media_responsive_thumbnail:dev-3431911-automated-drupal-11#37e476ed5555d8b4d63c273a581da67ebd2ee445 as 1.x-dev"

composer require 'drupal/vlsuite:^2.1'

crzdev opened merge request !52

  • crzdev committed d92620ce on 2.x 
    Issue #3435575: Automated Drupal 11 compatibility fixes for vlsuite
crzdev’s picture

crzdev commented

Fixed config UI 2.x for core 11 with compatibility with ^10.3, also indcluded minimal test coverage (all config pages responds with response code 200).

crzdev’s picture

crzdev commented
Related issues: +#3479416: Customized installation refinement

Removed composer dependencies (& moved as suggestions) of:
- layout_builder_at
- media_responsive_thumbnail

Those dependencies are now managed by those using new vlsuite_demo preset (old vlsuite_shuttle now with just basis for a customized installation):
https://www.drupal.org/project/vlsuite/issues/3479416

That will be included into release notes when new stable version comes.

NOTE: That just will affect to new 2.x version, 1.x keeps as it is. That way those modules won't affect for new installations in core 11 & no complete demo preset is needed. For those cases here is solution (core 11 + complete demo preset): https://www.drupal.org/project/vlsuite/issues/3435575#comment-15800647

  • crzdev committed 1c564b2d on 2.x 
    Issue #3435575: Define global vlsuite field type categories yml
crzdev’s picture

crzdev commented

Fixed "AssertionError: "..." must be defined in MODULE_NAME.field_type_categories.yml in assert()" when creating new field for core 11 into 2.x

  • crzdev committed dd92acc3 on 2.x 
    Issue #3435575: Adjust block icon upload validator

  • crzdev committed cf6088fc on 2.x 
    Issue #3435575: Fix block content type icon save ensure schema...

crzdev closed merge request !41

crzdev’s picture

crzdev commented
Status: Needs work » Fixed

All adjustments ready, it should be working with core 11, for existing sites installed by shuttle: https://www.drupal.org/project/vlsuite/issues/3435575#comment-15800647

Closing this issue, 2.x release out today

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.