Problem/Motivation

This module code includes RenderElement::setAttributes(), which is deprecated in Drupal 10.3 and removed in Drupal 12: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...

CommentFileSizeAuthor
#5 Drupal-11-compatible-3469293-5-AFTER.png92.57 KBchandansha
#5 Drupal-11-compatible-3469293-5-BEFORE.png161.78 KBchandansha
#4 Screenshot from 2024-08-21 11-35-16.png18.98 KBrajan kumar@2026

Issue fork media_library_form_element-3469293

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mark_fullmer created an issue. See original summary.

rajan kumar@2026’s picture

rajan kumar@2026 commented
Assigned: Unassigned » rajan kumar@2026

Rajan Kumar@2026 opened merge request !17

rajan kumar@2026’s picture

rajan kumar@2026 commented
Assigned: rajan kumar@2026 » Unassigned
Status: Active » Needs review
StatusFileSize
new Screenshot from 2024-08-21 11-35-16.png18.98 KB

Hi @mark_fullmer

I have fixed the issue to create a Drupal 11-compatible release and have created a MR. Please see the attached screenshot for reference. Thank you.

chandansha’s picture

chandansha commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Drupal-11-compatible-3469293-5-BEFORE.png161.78 KB
new Drupal-11-compatible-3469293-5-AFTER.png92.57 KB

i have tested MR 17.Now module is compatible for Drupal 11.
i move it to RTBC.
thanks!!

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

Please note that the merge request here references a deprecation that was introduced in Drupal 10.3 and will be removed in Drupal 12.0.0. Therefore, the changes staged in this merge request are not required for Drupal 11 compatibility.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Title: Create Drupal 11-compatible release » Drupal 12 compatibility
Issue summary: View changes
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Reviewed & tested by the community » Needs work

Reviewing the code change in the merge request, I don't believe this is implemented correctly. It "fixes" the problem by removing code. Per https://www.drupal.org/node/3436275 , we should use RenderElementBase instead of RenderElement. We should also probably add a backwards compatibility check per https://www.drupal.org/node/3379306

Setting to "Needs work"

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Title: Drupal 12 compatibility » RenderElement is deprecated in drupal:10.3.0 and is removed from drupal:12.0.0

bluegeek9 made their first commit to this issue’s fork.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.