Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3435003-4.patch | 1.13 KB | chucksimply |
| #2 | tiny_slider.1.1.x-dev.rector.patch | 388 bytes | project update bot |
Issue fork tiny_slider-3435003
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #4
chucksimply commentedHere's a patch that includes the .info update along with the change from
Drupal\Core\Asset\libraryDiscoverytoDrupal\Core\Asset\LibraryDiscoveryCollector. Working flawlessly on 1.1.0-rc4 on Drupal 11.Comment #5
vinayakmk47Hello, the module is compatible with drupal11 after applying the patch, Thanks
Comment #6
vinodhini.e commentedHi,
Reproduced this issue in Drupal 11 and applied patch #4. The module is working as expected.
Thanks!
Comment #7
afagiolifollowing
Comment #8
vinodhini.e commentedComment #9
gettysburger commentedI am having trouble applying patch #4.
I added the patch:
"drupal/tiny_slider": {
"Automated Drupal 11 compatibility fixes for tiny_slider": "https://www.drupal.org/files/issues/2025-02-11/3435003-4.patch"
}
I added the module to drupal-lenient:
I then run composer require 'drupal/tiny_slider:1.1.x-dev@dev'
...and it seems to install the module but not the patch. Thanks so much for the help.:
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
- Syncing drupal/tiny_slider (dev-1.1.x 73e799c) into cache
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
- Installing drupal/tiny_slider (dev-1.1.x 73e799c): Cloning 73e799cd70 from cache
- Applying patches for drupal/tiny_slider
https://www.drupal.org/files/issues/2025-02-11/3435003-4.patch (Automated Drupal 11 compatibility fixes for tiny_slider)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2025-02-11/3435003-4.patch
Comment #11
coulton commentedAny idea when an updated when a version of this is being released as this is the only module that is preventing us from upgrading to Drupal 11
Comment #12
gogowitsch commentedHere is how you can install the Drupal 11 version of this module:
1. Go to the terminal of your server, for example using SSH.
2. Switch to the directory containing the file
composer.json2. Run this command:
composer config repositories.tiny_slider-drupal-11 vcs https://git.drupalcode.org/issue/tiny_slider-3435003.git && composer require drupal/tiny_slider:dev-project-update-bot-only -WWe don’t need these steps anymore once there is an official release for Drupal 11.
Comment #13
webengr commentedif
Comment #15
ipwa commentedComment #17
ipwa commented@chucksimply thanks for the patch I could not use it because the drush command got refactored in #3505239: Refactor custom drush command to download library
@Gogowitsch thanks for the MR in the end I needed to update the instructions so I just did a commit.
Wanted to credit both of you but UI was not working so I could get the right command with your credit, sorry for being so lazy and not doing it manually
Comment #18
gogowitsch commentedThank you, @ipwa, for taking the time to bring the module forward! No worries, all good.