Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#31 3435298-4.patch5.95 KBjeroen dost
#13 remote_stream_wrapper.2.x-dev.rector.patch4.4 KBproject update bot
#6 remote_stream_wrapper.2.x-dev.rector.patch4.41 KBproject update bot
#6 interdiff-last-bot.6916785.txt3.97 KBproject update bot
#2 remote_stream_wrapper.2.0.0.rector.patch2.95 KBproject update bot

Issue fork remote_stream_wrapper-3434168

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new remote_stream_wrapper.2.0.0.rector.patch2.95 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !11

jrglasgow made their first commit to this issue’s fork.

jrglasgow opened merge request !12

project update bot’s picture

project update bot commented
Version: 2.0.0 » 2.x-dev
StatusFileSize
new interdiff-last-bot.6916785.txt3.97 KB
new remote_stream_wrapper.2.x-dev.rector.patch4.41 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-217342

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.4
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.3

scott_earnest made their first commit to this issue’s fork.

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
commented
Issue summary: View changes
Status: Needs review » Needs work

Re: MR !12

Stream wrapper must not have a constructor. Because this breaks fopen() and alike functions:

[error]  ArgumentCountError: Too few arguments to function Drupal\remote_stream_wrapper\StreamWrapper\HttpStreamWrapper::__construct(), 0 passed and exactly 1 expected in Drupal\remote_stream_wrapper\StreamWrapper\HttpStreamWrapper->__construct() (line 53 of .../web/modules/contrib/remote_stream_wrapper/src/StreamWrapper/HttpStreamWrapper.php) #0 [internal function]: Drupal\remote_stream_wrapper\StreamWrapper\HttpStreamWrapper->__construct()

Look at core implementations of StreamWrapperInterface - they all use static calls to \Drupal::service(...) or similar.

pingwin4eg changed the visibility of the branch 2.x to hidden.

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
commented
Assigned: Unassigned » pingwin4eg

Working on removing constructor from stream wrapper.

pingwin4eg changed the visibility of the branch project-update-bot-only to hidden.

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
commented
Assigned: pingwin4eg » Unassigned
Status: Needs work » Needs review

PhpUnit previous major (Drupal: 10.3.6, PHP 8.1.30) and next minor (Drupal: 11.1.0-dev, PHP 8.3.13) both pass on all tests except one for HttpMimeTypeGuesserTest, but that should be fixed by #3486396: Fix mime-type guesser for Drupal >= 10.3.2.

I'm thinking (not sure) - whether the auto-testing for file functions (fopen, etc.) is needed.

project update bot’s picture

project update bot commented
Issue summary: View changes
StatusFileSize
new remote_stream_wrapper.2.x-dev.rector.patch4.4 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-392907

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.6
  2. mglaman/phpstan-drupal: 1.3.2
  3. palantirnet/drupal-rector: 0.20.3
pawelgorski87’s picture

pawelgorski87 commented
Assigned: Unassigned » pawelgorski87
Issue summary: View changes
yorchperaza’s picture

yorchperaza commented

Hello! Is there any estimate of obtaining the compatibility merge and being able to have a Drupal 11 version of the module? I need help with something, I am available for anything.

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
commented
Status: Needs review » Needs work

@pawelgorski87 Why don't you read issue comments? Please read them, and revert your breaking changes.

pawelgorski87’s picture

pawelgorski87 commented

@pingwin4eg, right sorry. Constructor removed.

pawelgorski87’s picture

pawelgorski87 commented

@pingwin4eg I used Your patch for Guesser. Thank you.
Now all pipelines passed. Please test and review.

pawelgorski87’s picture

pawelgorski87 commented
Assigned: pawelgorski87 » Unassigned
Priority: Normal » Major
Status: Needs work » Needs review
gpietrzak’s picture

gpietrzak
Primary language Polish
Location Wrocław
commented

I reviewed the code and tested the module locally. I changed the image media type to accept remote streams and successfully added some new items. It worked fine (provided the image styles are not configured to use webp).

pawelgorski87’s picture

pawelgorski87 commented
Status: Needs review » Reviewed & tested by the community
andras_szilagyi’s picture

andras_szilagyi commented

Looks good, works fine also in my tests

yorchperaza’s picture

yorchperaza commented

Looks good, works for me!

joevagyok made their first commit to this issue’s fork.

yorchperaza’s picture

yorchperaza commented

Is there any estimate to get this merge into the dev module?

msnassar’s picture

msnassar commented

RTBC++
I have tested it with media_avportal https://www.drupal.org/project/media_avportal/issues/3431855. All works as expected.

plopesc made their first commit to this issue’s fork.

plopesc’s picture

plopesc
he/him
Primary language Spanish
commented

Tested locally and works as expected.
Made some minor updates in the MR to reduce boilerplate code that can be removed once the module only supports PHP 8.1+

Hope to get a D11 release soon!

aaronbauman made their first commit to this issue’s fork.

jeroen dost’s picture

jeroen dost commented

This removed problems reported by Upgrade status and marks it Drupal 11 ready. I think it is indeed ready for a D11 release.

jeroen dost’s picture

jeroen dost commented
StatusFileSize
new 3435298-4.patch5.95 KB

Ignore the patch in this attachment. It was for another contrib module.

At closer inspection I still see 25 remaining problems reported by upgrade status. Nearly all are about "Dynamic call to static method" in tests using Assert. And one for "Call to function in_array() requires parameter #3 to be set."
Do we need to fix this before we can move to D11, or can we add a patch later to fix these issues later?

jeroen dost’s picture

jeroen dost commented

On yet another closer inspection, I had "phpstan/phpstan-strict-rules" in my composer file. I removed that and I see no problems anymore. So this should be ready for release.

nagy.balint’s picture

nagy.balint commented

  • nagy.balint committed 2bc69d61 on 2.x 
    Issue #3434168 by pawelgorski87, scott_earnest, pingwin4eg, plopesc,...
nagy.balint’s picture

nagy.balint commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

donquixote’s picture

donquixote commented

Hello,
just a note.
This change went into a patch release 2.1.1.
But the added types on properties in HttpStreamWrapper actually cause BC breaks for classes that extend it.