Problem/Motivation

Method return*() of class PHPUnit\Framework\TestCase is deprecated in PHPUnit 10.

Proposed resolution

Use $double->willReturn*() instead.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3433052

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !7164

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Status: Active » Needs review
Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Said it before and will say it again:

Replacement makes sense, couldn't find any other occurrences than the ones in the MR, Green tests => RTBC.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake as a volunteer commented
Title: Fixed remaining return*() methods of class PHPUnit\Framework\TestCase deprecated in PHPUnit 10 » Fix remaining return*() methods of class PHPUnit\Framework\TestCase deprecated in PHPUnit 10

  • catch committed a65d1f9d on 10.3.x 
    Issue #3433052 by mondrake: Fix remaining return*() methods of class...

  • catch committed d671f38a on 11.x 
    Issue #3433052 by mondrake: Fix remaining return*() methods of class...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.