Problem/Motivation

I just got this message after enabling some modules, so I have no idea which view is the problem!

This message should give the name of the view.

Steps to reproduce

Proposed resolution

Remaining tasks

CommentFileSizeAuthor
#6 Bildschirmfoto 2024-03-21 um 10.58.03.png58.67 KBsimhag

Issue fork search_api-3426614

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joachim created an issue. See original summary.

misterdidi made their first commit to this issue’s fork.

misterdidi opened merge request !113

misterdidi’s picture

misterdidi CreditAttribution: misterdidi at Adimeo commented

The warning message being displayed in hook_view_presave() if no caching option is manually set by the user, I added the view label (not sure view id would be more understandable) to the warning message so that user is aware of which view was automatically updated.

misterdidi’s picture

misterdidi CreditAttribution: misterdidi at Adimeo commented
Status: Active » Needs review
simhag’s picture

simhag CreditAttribution: simhag at Bitmade commented
Status: Needs review » Reviewed & tested by the community
FileSize
Bildschirmfoto 2024-03-21 um 10.58.03.png58.67 KB

I have reviewed the PR and can confirm that the message now includes the label. (See screenshot).
Even if I agree that an ID of the view might be more meaningful, the label is definitely an enrichment for the user from my point of view.

RTBC +1

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Makes sense, thanks. Merged.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.