Problem/Motivation

Drupal 11 may be released already in June 2024.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork leaflet-3425163

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ressa created an issue. See original summary.

ressa opened merge request !35

ressa’s picture

ressa
he/him
commented
Status: Active » Needs review
ressa’s picture

ressa
he/him
commented
Title: Support Drupal 11 » Support Drupal 11 in Leaflet
orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Status: Needs review » Reviewed & tested by the community

I've tested it locally. @ressa, thanks for the D11 compatibility:)

itamair’s picture

itamair commented
Related issues: +#3430742: Automated Drupal 11 compatibility fixes for geofield

ok ... thanks @here!
I am going to sit for final green flag for merging this Geofield Drupal 11 compatibility Issue:
https://www.drupal.org/project/geofield/issues/3430742
and then will proceed with this one also ... :-)

  • itamair committed 1d9b36a4 on 10.2.x authored by ressa 
    Issue #3425163 by ressa, Orkut Murat Yılmaz: Support Drupal 11 in...
itamair’s picture

itamair commented
Status: Reviewed & tested by the community » Fixed

Thanks. This was merged and is going to be part of the next Leaflet 10.2.18 incoming release.

ressa’s picture

ressa
he/him
commented

Thanks @itamair, and @Orkut Murat Yılmaz for reviewing!

To prevent abuse, for example by creating a branch or uploading a file only to get credit (I searched, but can't find the issue where it was decided), credits are no longer added automatically. So the maintainer needs to remember do it ...

A maintainer has not commented and given credit yet.

ressa’s picture

ressa
he/him
commented
Related issues: +#3395901: Use Gitlab CI in Simplenews

I found the issue, where I asked about the history about disabling automatic crediting, and @fjgarlin kindly cleared it up:

It wasn't just one issue. We started turning off the auto-crediting features (mostly due to credit gaming but also to be more in line with the future new system) more than a year ago, in several passes. I can't remember which issues were the ones but I'm sure they'll be in the "drupalorg" queue.

In the Gitlab issue system, where Drupal issues are moving soon, crediting will be part of the process of closing an issue, from #3395901-28: Use Gitlab CI in Simplenews:

We could create an automated message, but that will actually happen when we are in "GitLab issues" as it is already implemented via a webhook when closing the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ressa’s picture

ressa
he/him
commented

What is strange is that it says (#7) "Issue #3425163 by ressa, Orkut Murat Yılmaz: Support Drupal 11 in..." but under "Credit & committing", it says this:

A maintainer has not commented and given credit yet.

Though it's not listed under my credited issues for Leaflet:

  • Show the map at default zoom in form and display updated 5 Dec 2023 at 23:34 CET
  • Fix dead Leaflet API reference and Twig Documentation links updated 17 Jul 2023 at 13:24 CEST

From Leaflet issues credited to ressa.

ressa’s picture

ressa
he/him
commented

I just checked, and found two issue where I could have gotten credit as well ...