Problem/Motivation

Drupal\feeds\Feeds\Fetcher\HttpFetcher references \Drupal\Core\File\FeedsFileSystemInterface which does not exist. I think this should point to Feeds own Drupal\feeds\File\FeedsFileSystemInterface.

  /**
   * Drupal file system helper for Feeds.
   *
   * @var \Drupal\Core\File\FeedsFileSystemInterface
   */
  protected $feedsFileSystem;

  /**
   * Constructs an UploadFetcher object.
   *
   * @param array $configuration
   *   The plugin configuration.
   * @param string $plugin_id
   *   The plugin id.
   * @param array $plugin_definition
   *   The plugin definition.
   * @param \GuzzleHttp\ClientInterface $client
   *   The Guzzle client.
   * @param \Drupal\Core\Cache\CacheBackendInterface $cache
   *   The cache backend.
   * @param \Drupal\Core\File\FileSystemInterface $file_system
   *   The Drupal file system helper.
   * @param \Drupal\Core\File\FeedsFileSystemInterface $feeds_file_system
   *   The Drupal file system helper for Feeds.
   */
  public function __construct(array $configuration, $plugin_id, array $plugin_definition, ClientInterface $client, CacheBackendInterface $cache, FileSystemInterface $file_system, FeedsFileSystemInterface $feeds_file_system) {
    $this->client = $client;
    $this->cache = $cache;
    $this->fileSystem = $file_system;
    $this->feedsFileSystem = $feeds_file_system;
    parent::__construct($configuration, $plugin_id, $plugin_definition);
  }

Steps to reproduce

Proposed resolution

Annotations referencing \Drupal\Core\File\FeedsFileSystemInterface should be changed to \Drupal\feeds\File\FeedsFileSystemInterface in
Drupal\feeds\Feeds\Fetcher\HttpFetcher

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

murrow created an issue. See original summary.

abhishek_gupta1’s picture

Assigned: Unassigned » abhishek_gupta1
abhishek_gupta1’s picture

Assigned: abhishek_gupta1 » Unassigned
Status: Active » Needs review
FileSize
1.13 KB

@murrow, I have changed as per your proposed resolution. and its working, please kindly review the patch file .

murrow’s picture

@abhishek_gupta1, this looks good to me. I have applied the patch and everything is working as expected. Many thanks

MegaChriz’s picture

Priority: Normal » Minor
Status: Needs review » Fixed

Thanks for the patch and the report! #3 is committed.

I also changed the priority of this issue to "Minor" because there are no functional changes, only a fix in a comment.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.