Hello and thanks for the great module,

Problem/Motivation

Can you provide support for Encrypt module too? It is a dependency for 2FA and we cannot use both modules, unfortunately.

Best,
Orkut

Comments

Orkut Murat Yılmaz created an issue. See original summary.

kartagis’s picture

Status: Active » Postponed (maintainer needs more info)

What feature of encrypt might iyzipay need?

orkutmuratyilmaz’s picture

Status: Postponed (maintainer needs more info) » Active

When we install iyzipay, it installs Encryption module, because it's a dependency. After the installation, it starts a conflict between Encrypt and Encryption modules.

Encrypt module is being used by the variety of modules, especially in Drupal 10. TFA 2.0.x module uses it as a dependency.

I've examined the code of the iyzipay module and I've noticed that the module uses Encryption as service:

On the 182nd line of src/Plugin/Commerce/PaymentGateway/IyzipayOnsite.php, it is defined as a variable:

$encryption_service = \Drupal::service('encryption');

Also, on the 26th line of src/Plugin/Commerce/PaymentMethodType/FullCreditCard.php too.

The modules use Encrypt (instead of Encryption) calls the Encrypt via api like:

use Drupal\encrypt\EncryptionProfileInterface;
use Drupal\encrypt\EncryptServiceInterface;
use Drupal\encrypt\Entity\EncryptionProfile;

Adding Encrypt functionality will be so nice for more advanced security options to iyzico module.

kartagis’s picture

Fixed and committed to 2.x, thanks.

kartagis’s picture

Status: Active » Fixed
orkutmuratyilmaz’s picture

Thanks for this feature:)

kartagis’s picture

Have you tested it out yet?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.