Problem/Motivation

Images inserted by useing the media libtrary button are not shown in the edit form

Steps to reproduce

add an article or a blog post
give it a title
click the media library button
upload an image
insert it in the body field
click save

see it live here: https://youtu.be/1i2hIK9znL8

Proposed resolution

  • Provides Varbase Media CKEditor 5 integration with Drimage
  • Images:
    • Responsive small image with containers that are 25% wide until a breakpoint.
    • Responsive medium image with containers that are 50% wide until a breakpoint.
    • Responsive large image with containers that are 100% wide until a breakpoint.
  • Videos/Remote videos
    • Responsive small video with containers that are 25% wide until a breakpoint.
    • Responsive medium video with containers that are 50% wide until a breakpoint.
    • Responsive large video with containers that are 100% wide until a breakpoint.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-10.0.0-rc2, varbase_media-10.0.0-beta13

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix: ( Watch the Video )

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Comments

Joachim Namyslo created an issue. See original summary.

joachim namyslo’s picture

Title: Node edit form doesN#t show inline images when inserted useing the media library button. » Node edit form doesn't show inline images when inserted useing the media library button.
joachim namyslo’s picture

Issue summary: View changes
rajab natshah’s picture

Thank you, Joachim, for reporting.

The video is well explained
I confirm the issue.

Seems that we need to have this fixed for the default Drupal 10 Core Media inline Embed, plus the Embed, or Entity Embed Media under CKEditor 5

They had a new release.
It is the right time to optimize Varbase Editor before moving to release the 10.0.0 stable release.

Thanks again for filing the issue.
Moving with Varbase 10 from Beta to RC and stable

pimok3000’s picture

The patch for the entity_embed module from here:
https://git.drupalcode.org/project/entity_embed/-/commit/ac6f2fe13b18f5f...
is already applied in the version included in Beta2. But it does not solve the issue.

rajab natshah’s picture

Title: Node edit form doesn't show inline images when inserted useing the media library button. » Fix not showing inline images in Node edit form ( CKEditor 5 ) when inserted using the media library button
Project: Varbase - The Ultimate Drupal CMS Starter Kit (Bootstrap Ready) » Varbase Editor
Version: 10.0.0-beta2 » 10.0.x-dev
rajab natshah’s picture

Issue tags: +varbase-10.0.0
rajab natshah’s picture

Issue tags: -varbase-10.0.0 +varbase-10.0.0-rc2
ahmad abbad’s picture

I'm confirming the issue, and it's maybe be better to make it a CKEditor plugin

rajab natshah’s picture

Assigned: Unassigned » rajab natshah

Noted;

Agrees on that, custom CKEditor integration plugin Drimage + Embed Entity or Media Embed

rajab natshah’s picture

rajab natshah’s picture

Project: Varbase Editor » Varbase Media
rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed 42759d89 on 10.0.x
    Issue #3402234: Fix not showing inline images in Node edit form (...

  • Rajab Natshah committed e1c47bb7 on 10.0.x
    Issue #3402234: Fix not showing inline images in Node edit form (...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase_media-10.0.0-beta13
StatusFileSize
new462.39 KB

After the fix: ( Watch the Video )

rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
Issue tags: -varbase-10.0.0-rc2 +varbase-10.0.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes
Issue tags: -varbase-10.0.0 +varbase-10.0.0-rc2
rajab natshah’s picture

✅ Released varbase-10.0.0-rc2