--------------------------------------------------------------------------------
58 | ERROR | The array declaration extends to column 110 (the limit is 80).
| | The array content should be split up over multiple lines
99 | ERROR | Missing short description in doc comment
100 | ERROR | Missing parameter comment
100 | ERROR | Missing parameter type
101 | ERROR | Missing parameter comment
102 | ERROR | Missing parameter comment
103 | ERROR | Description for the @return value is missing
310 | ERROR | Description for the @return value is missing
329 | ERROR | Missing parameter comment
329 | ERROR | Missing parameter type
616 | WARNING | Line exceeds 80 characters; contains 82 characters
629 | ERROR | Missing parameter comment
630 | ERROR | Missing parameter comment
654 | ERROR | Missing parameter comment
654 | ERROR | Missing parameter type
656 | ERROR | Description for the @return value is missing
672 | ERROR | Missing parameter comment
672 | ERROR | Missing parameter type
674 | ERROR | Description for the @return value is missing
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | new_3369441.patch | 3.62 KB | sonam_sharma |
| #2 | 3369441.patch | 1.16 KB | sonam_sharma |
| Screenshot 2023-06-24 121738.jpg | 3.9 KB | sonam_sharma |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
sonam_sharma commentedComment #3
froboyHi @sonam_sharma, thanks and welcome! We appreciate you testing this project, but if you're running automated tests could you please ensure you're making high-value contributions? Unsolicited one-line patches are appreciated, but can also be considered "gaming the system".
We appreciate contributions, but we request that you:
1. open an MR with it instead.
2. Show logs that you're resolving linting issues for the entire project instead of just a single file.
Thanks.
Comment #4
froboyComment #5
sonam_sharma commentedhello @froboy,
I have fixed remaining issues reported by phpcs.
please review the patch
Comment #6
froboy@sonam_sharma thanks, that's closer. please show your work by pasting in the phpcs command that you ran to get those results so we can validate. Also, see item 1 in #3 above - this should be in a Merge Request instead of a patch. Learning the MR process will help you help others even better! Thanks.
Comment #8
froboy@sonam_sharmaI see the merge request open, but it looks like there is no code pushed to the branch.
Now that the issue fork is open, you'll need to use the "Show Commands" link above to connect the branch to your local and commit the changes in the patch. Alternatively, you could use the GitLab Web IDE to spin up a copy of the branch, upload the patch, apply it, and commit it.
Thanks for going through the process with us. Please let me know if you have any questions.
Comment #10
bharath-kondeti commentedhello @froboy, Updated the patch changes into the merge request. Please review the same.
For verified used this command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/openy_carnation
Comment #11
avpadernoThe issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
Comment #14
podaroktnx