Problem/Motivation

Setting the field cardinality to 2 and selecting 3 roles will lead to an error. This is expected, but there is no information, on how many roles can be picked, based on the cardinality of the field.

Steps to reproduce

Proposed resolution

Give an information about how many roles can be selected.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 2023-05-30 16_27_37-Edit Article sdadasdasd _ Drush Site-Install.png9.97 KBGrevil

Issue fork entity_access_by_role_field-3363577

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Grevil created an issue. See original summary.

Grevil opened merge request !18

Grevil’s picture

Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented
Status: Active » Needs review
FileSize
2023-05-30 16_27_37-Edit Article sdadasdasd _ Drush Site-Install.png9.97 KB

Done, please review! I am still not 100% sure about the "unlimited" case, but any other approach doesn't seem very good either. See screenshot:
screenshot

Please review!

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Status: Needs review » Needs work

Sorry, but this is at the wrong field. Has to be suffixed at the "When the user has the following roles:"-field.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented

But we could use this change to make both variables emphasized (<em>) via % instead of @:
@operations => %operations
@cardinality => %cardinality

(remove the manual <em>)

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Assigned: Unassigned » Grevil
Grevil’s picture

Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented
Status: Needs work » Needs review

Ok done, please rereview.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Status: Needs review » Reviewed & tested by the community

RTBC! :)

  • Anybody committed 93182bf1 on 2.0.x authored by Grevil 
    Issue #3363577 by Grevil, Anybody: Setting the field cardinality to 2...
Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented
Status: Reviewed & tested by the community » Fixed

Merged!

Grevil’s picture

Grevil CreditAttribution: Grevil as a volunteer and at DROWL.de commented
Assigned: Grevil » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.