Problem/Motivation
- Remove jQuery dependency from the once feature
- #2402103: Add once.js to core
- #3183149: Deprecate jquery.once and use the new once lib
Proposed resolution
- Switch from
core/jquery.oncetocore/once - Refactor the
$browser_select.once('register-row-click').click(function (event)action
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ✅ Testing to ensure no regression
- ➖ Automated unit testing coverage
- ➖ Automated functional testing coverage
- ➖ UX/UI designer responsibilities
- ✅ Readability
- ✅ Accessibility
- ✅ Performance
- ➖ Security
- ➖ Documentation
- ✅ Code review by maintainers
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Release notes snippet
- ✅ Release Varbase 10.0.0-beta1, entity_browser_enhanced-2.0.0-beta1
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Issue #3362495: Switched from
core/jquery.oncetocore/once
Issue fork entity_browser_enhanced-3362495
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3362495-switch-from-corejquery.once
changes, plain diff MR !2 /
changes, plain diff MR !3
Comments
Comment #7
rajab natshahComment #9
rajab natshahComment #10
rajab natshahComment #11
rajab natshahComment #12
rajab natshah✅ Released entity_browser_enhanced-2.0.0-beta1
Comment #13
rajab natshahComment #14
rajab natshahComment #16
rajab natshah✅ Released Varbase 10.0.0-beta1