Problem/Motivation

Admin Toolbar 3.3.1 added some changes for how keyboard users can navigate, this has some impacts on our end as well.

Until we have fixed the issues and made it compatible I'd consider staying at 3.3.0.

The fix is already in the works and should be available in the next few days.

Steps to reproduce

Install 3.3.1

Proposed resolution

Solve compatibility issues

Remaining tasks

Publish MR

User interface changes

New chevron button will be added to horizontal nav items for better keyboard navigation

Classic, legacy Modern Vertical (no change)

API changes

-

Data model changes

-

CommentFileSizeAuthor
#9 Capture d’écran du 2023-05-05 11-58-59.png22.28 KBfabsgugu
#6 classic_3.3.1.png386.13 KBsaschaeggi
#6 horizontal_3.3.1.png390.72 KBsaschaeggi
#6 vertical_3.3.1.png416.2 KBsaschaeggi

Issue fork gin-3357237

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

saschaeggi created an issue. See original summary.

mlncn’s picture

mlncn commented
Related issues: +#3357210: How to remove newly added blue arrows at top level of menu
mlncn’s picture

mlncn commented
Related issues: -#3357210: How to remove newly added blue arrows at top level of menu +#3357166: Upset theme since update to 3.3.1

Corresponding issue on Admin Toolbar: #3357166: Upset theme since update to 3.3.1

saschaeggi’s picture

saschaeggi
he/him
commented
Priority: Normal » Critical

saschaeggi opened merge request !250

saschaeggi’s picture

saschaeggi
he/him
commented
Issue summary: View changes
StatusFileSize
new vertical_3.3.1.png416.2 KB
new horizontal_3.3.1.png390.72 KB
new classic_3.3.1.png386.13 KB

  • saschaeggi committed fc06460f on 8.x-3.x 
    Issue #3357237: [admin_toolbar] 3.3.1 compatibility issues
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Fixed
fabsgugu’s picture

fabsgugu commented
StatusFileSize
new Capture d’écran du 2023-05-05 11-58-59.png22.28 KB

Hello,

There is a side effect after this update.
For the dark theme, 3rd menu links appear white.

I don't have the problem on version 3.0-rc2

I think it's caused by this change:

.toolbar .level-2 > ul,
.gin--dark-mode .toolbar .toolbar-toggle-orientation {
  background-color: var(--gin-bg-layer2);
}

.toolbar .level-2 > ul, was removed

saschaeggi’s picture

saschaeggi
he/him
commented

@Fabsgugu we should have fixed this already in 8.x-3.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.