Upset theme since update to 3.3.1

I'm also seeing this with Gin. It looks like it was introduced in #3286466: Tabbing order does not satisfy 508 accessibility requirements. I'm not sure if the fix should happen here or in Gin.

Also seeing the same thing when applied in dev environment.

I also see extra arrow after updating to 3.3.1 (see screen capture https://ibb.co/nrrXVCs ).

I see it only in Gin (which I prefer), but when I switch back to Claro, it is fine.

I'm seeing the exact same thing as well. Seems like a regression. And given the disruption it is causing, I think this should be be bumped to a major. Hmm, or maybe stay at normal. But it _is_ annoying.

Subscribe, this is very annoying ;)

I feel this is major (very hard to use the admin menu!), although maybe it ought to be fixed in Gin Toolbar— which has an issue for it already too: #3357237: [admin_toolbar] 3.3.1 compatibility issues

Cross-linking as there definitely should be coordination in the fixing.

i don't use the gin theme nor the gin toolbar but in contrast to #5 i consider the change already problematic in claro. functionally from a keyboard user perspective the changes the issue #3286466: Tabbing order does not satisfy 508 accessibility requirements introduced are important. therefore i would vote against removing those buttons. but I wonder if it wouldn't make more sense to improve the styling of those blue buttons in core in general, since those blue buttons are used on the vertical toolbar when the admin_toolbar is not installed yet? on the vertical toolbar i haven't really noticed those blue buttons, probably one of the reasons i've always avoided using the vertical toolbar, but with the patch introducing those buttons also to the horizontal toolbar i ran into an accessibility related issue personally. my attention is drawn to those blue buttons. it is really really cognitively challenging to focus onto the icons and labels of each menu item in between those blue buttons.
as a starting point, after noticing those changes the new release of admin_toolbar introduced i've searched a bit on slack and found the comments by @itmaybejj in a thread in the #accessibility channel on the drupal slack. his suggested changes lower the affordance of those buttons and would already solve the stylistic problem from my perspective. or at least they could be take as a starting point how to style those buttons in core? and on a sidenote the blue button (without admin_toolbar installed) is missing a color change on hover like for all the other interactive ui components in claro.

Same issue for me too.

Same over here. Please rollback to 3.3.0 when everything was fine. No apparent error but a dramatic reduction of usability.

On Adaptive Theme the admin toolbar cvers the progress bar when installing a new module. I am running Domain Access and have not checked the other domains with their differrent themes

Gin maintainer here ✌️

As a quick heads up, we have addressed the admin_toolbar 3.3.1 incompatibility issues directly in Gin with #3357237: [admin_toolbar] 3.3.1 compatibility issues. It's already available in the latest 8.x-3.x-dev branch and we'll push a new release soon.

ℹ️ You have two options until we release a new Gin version:
1. You can stay on/downgrade to admin_toolbar 3.3.0 and Gin 8.x-3.0-rc2 for now (= no change)
2. Use Gin's 8.x-3.x-dev branch until we file a new release (= includes the fixes to work with 3.3.1)

Such a quick turn around on a fix. THANK YOU!

Facing the same issue

I saw the same issue in my custom bootstrap theme and just added the following SCSS until this is sorted out.

/*
 * May 1/2023: Fix for admin_toolbar styling after updating to 3.3.1
 * https://www.drupal.org/project/admin_toolbar/issues/3357166
 */

.toolbar-menu-administration {
  ul.toolbar-menu {
    .menu-item {
      .toolbar-handle {
        vertical-align: top;
      }
    }
  }
}

Hi. Along the same lines, I am seeing a different css issue appearing after updating.

admin.toolbar.css
line 28
.menu-item a:focus,
.toolbar .toolbar-icon.toolbar-handle:focus {
background: #abeae4;
}

This line in the css is too generic and should be applied just to the the links in the toolbar, not site wide. Having to override this in the theme doesn't make sense.

This is obviously only an issue when a user is logged in, but still should be fixed.

Thanks.

I'm closing this and I think we should try to fix the problem in #3286466: Tabbing order does not satisfy 508 accessibility requirements. The code was reverted and a new release is coming in a few minutes.