Problem/Motivation

After enable the admin toolbar module with gin theme, in top navigation Local Task menu item alignment not matched with other menu item. Need to keep same theme to all like - shortcut's, admin items list.

Steps to reproduce

  1. Install the gin theme and admin toolbar module
  2. navigate to top navigation -> local task menu item -> hover -> menu item right align
CommentFileSizeAuthor
#8 3355036-with-patch.png182.33 KBmartijn de wit
#8 3355036-with-bug.png192.42 KBmartijn de wit
#6 gin-n3355036-6.patch762 bytesgalactus86
#3 after.png30.32 KBtanuja bohra
#3 before.png23.58 KBtanuja bohra
#2 Local-Task-menu-item-alignment-3355036-1.patch402 bytesHarish1688
#2 3355036-after-patch.png869.34 KBHarish1688
Local Task menu item alignment .png1.22 MBHarish1688

Issue fork gin-3355036

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Harish1688 created an issue. See original summary.

Harish1688’s picture

Harish1688 commented
Status: Active » Needs review
StatusFileSize
new 3355036-after-patch.png869.34 KB
new Local-Task-menu-item-alignment-3355036-1.patch402 bytes

Hi,

Created a patch for this issue, please review the patch Local-Task-menu-item-alignment-3355036-1.patch .
After patch image attached.

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before.png23.58 KB
new after.png30.32 KB

This patch is working, the menu items are now aligned to the left. Moving it to RTBC.

galactus86’s picture

galactus86 commented

I had this on my list to tackle... nice work! Verified the patch works!

galactus86’s picture

galactus86 commented
Assigned: Unassigned » galactus86
Status: Reviewed & tested by the community » Needs work

While initial test works, when reviewing the code I see that the dist/.css file was changed NOT the .scss file. So next time anyone compiles the CSS this change will be lost.

I'm going to take a few minutes and update.

galactus86’s picture

galactus86 commented
Assigned: galactus86 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new gin-n3355036-6.patch762 bytes

Updated the toolbar_secondary.scss file instead so it compiles correctly and won't get over written in the future. I also removed the float as a best practice.

Patch attached for review.

sahal_va made their first commit to this issue’s fork.

martijn de wit’s picture

martijn de wit
Primary language Dutch
Location 🇳🇱 The Netherlands
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3355036-with-bug.png192.42 KB
new 3355036-with-patch.png182.33 KB

Unsetting the float is a neater solution, then adding extra styling.

Using patch #6

The bug in our case:

with bug

With the patch:

with bug

thnx!

saschaeggi’s picture

saschaeggi
he/him
commented

Great, thanks y'all!

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed
sahal_va’s picture

sahal_va commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.