Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 interdiff.3353287.7.11.txt763 bytesDuaelFr
#11 3353287-8.x-1.x-deprecation-11.patch866 bytesDuaelFr
#7 3353287-8.x-1.x-deprecation.patch558 bytesDuaelFr

Issue fork ui_patterns-3353287

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DuaelFr created an issue. See original summary.

DuaelFr opened merge request !30

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Status: Active » Needs review

This MR is built on top of !29 from #3349079: [2.0.x] Move YAML discovery from ui_patterns_library to ui_patterns

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Version: 8.x-1.x-dev » 2.0.x-dev

Grimreaper made their first commit to this issue’s fork.

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented

Hi,

I made one comment in the review.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
FileSize
3353287-8.x-1.x-deprecation.patch558 bytes

Job done.
Bonus: here is a patch to deprecate the method in the 1.x branch

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Unassigned » Grimreaper

Hi,

Thanks looking at the MR.

Here is my comment for the deprecation patch.

+++ b/src/Element/PatternPreview.php
@@ -52,6 +52,9 @@ public static function processFields(array $element) {
     if (is_array($preview)) {

Should we also add a trigger_error? like

@trigger_error('AddressField is deprecated in address:8.x-1.3 and is removed from address:8.x-2.0. Use \Drupal\address\Plugin\migrate\field\AddressField instead. See https://www.drupal.org/project/address/issues/2912087', E_USER_DEPRECATED);

  • Grimreaper committed 0aa57509 on 2.0.x authored by DuaelFr 
    Issue #3353287 by DuaelFr, Grimreaper: [2.0.x] Remove unused escape...
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Version: 2.0.x-dev » 8.x-1.x-dev
Assigned: Grimreaper » Unassigned

MR merged on 2.0.x. Thanks!

Changing branch for the deprecation on 8.x-1.x.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
FileSize
3353287-8.x-1.x-deprecation-11.patch866 bytes
interdiff.3353287.7.11.txt763 bytes

#8: good point! Here is the updated patch. Thanks :)

Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Unassigned » Grimreaper

  • Grimreaper committed 90fba88e on 8.x-1.x authored by DuaelFr 
    Issue #3353287 by DuaelFr, Grimreaper: Mark PatternPreview::...
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper at Smile commented
Assigned: Grimreaper » Unassigned
Status: Needs review » Fixed

Merged.

Thanks. I have adapted the message to pass PHPCS.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.