Problem/Motivation

> Drupal\Core\Composer\Composer::upgradePHPUnit
PHP Fatal error: Declaration of Drupal\Tests\cron_example\Functional\CronExampleTest::setUp() must be compatible with Drupal\Tests\examples\Functional\ExamplesBrowserTestBase::setUp(): void in /var/www/html/modules/contrib/examples/modules/cron_example/tests/src/Functional/CronExampleTest.php on line 33

Steps to reproduce

Proposed resolution

  • Add typehint to ::setUp()
  • Change public ::setUp() to protected

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3342565-2.patch9.31 KBjungle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jungle created an issue. See original summary.

jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Active » Needs review
FileSize
3342565-2.patch9.31 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3342565-2.patch, failed testing. View results

  • jungle committed d54cded5 on 3.x 
    Issue #3342565 by jungle: Fix imcompatible ::setUp()
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Status: Needs work » Fixed
jungle’s picture

jungle
He/Him
Location Chongqing, China
CreditAttribution: jungle as a volunteer commented
Assigned: jungle » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.