Problem/Motivation

PHP deprecation notice: 

Deprecated function: Creation of dynamic property Drupal\pathauto\AliasCleaner::$punctuationCharacters is deprecated in Drupal\pathauto\AliasCleaner->getPunctuationCharacters() (line 332 of /var/www/html/web/modules/contrib/pathauto/src/AliasCleaner.php)

Steps to reproduce

Save an entity configured to autogenerate an alias

CommentFileSizeAuthor
#27 php8-2-notice-pathauto-3328670-27.patch2.75 KBandre.bonon
#2 php8.2notice-pathauto-3328670.patch424 byteshugronaphor

Issue fork pathauto-3328670

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hugronaphor created an issue. See original summary.

hugronaphor’s picture

hugronaphor commented
Status: Needs work » Needs review
StatusFileSize
new php8.2notice-pathauto-3328670.patch424 bytes

Status: Needs review » Needs work

The last submitted patch, 2: php8.2notice-pathauto-3328670.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

j-vee’s picture

j-vee commented
Status: Needs work » Reviewed & tested by the community

Tested & works fine!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

There's another strange test fail on PHP 8.2.

xen’s picture

xen commented
Status: Needs work » Reviewed & tested by the community

Tried running the tests on PHP 8.2 and Drupal 10 locally, and they ran fine. Think the failures might be a fluke.

bronismateusz’s picture

bronismateusz commented

I can confirm that with me the patch also works as expected.

ewout goosmann’s picture

ewout goosmann
Primary language Dutch
commented

I can also confirm that the patch is working.

urvashi_vora made their first commit to this issue’s fork.

urvashi_vora’s picture

urvashi_vora commented

The patch looks great and works fine for me as well.

RTBC ++

Thanks for the work.

urvashi_vora opened merge request !40

ankitv18 made their first commit to this issue’s fork.

arnaud-brugnon’s picture

arnaud-brugnon commented

Works like a charm (even if code quality can be better).

Be aware that if you don't use this patch is 8.2, you may have cache issue.
Because this patch solve a warning.
Warning are display by MessengerService
MessengerService kill cache when you display a message (surprise !)

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Priority: Normal » Major

+1 RTBC

murrow’s picture

murrow commented

+1 RTBC

raveen_thakur51’s picture

raveen_thakur51 commented

The patch is working fine for me. Can be moved to RTBC! And Thank You!!

szato’s picture

szato commented
Related issues: +#3363661: Deprecated function: Creation of dynamic property Drupal\pathauto\AliasCleaner::$punctuationCharacters is deprecated

Same work done in Deprecated function: Creation of dynamic property Drupal\pathauto\AliasCleaner::$punctuationCharacters is deprecated, also RTBC, so this issue is 2x ;)

pfructuoso’s picture

pfructuoso commented

This works to me too!

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Needs work

As noted above, the failing test still needs to be addressed in 8.2.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review

Hmm, these aren't failing locally for me.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

The entity ID test fail seems to be related to MySQL 8. The UI test fail is due to changes in 10.1 and not PHP 8.2, pretty tedious to fix.

  • Berdir committed ed2d4d30 on 8.x-1.x authored by urvashi_vora 
    Issue #3328670 by urvashi_vora, Berdir, hugronaphor, ankitv18: PHP 8.2...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Merged.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

@Berdir when can we expect the release for the same.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

@berdir: When we can expect the stable release with this fixes?

andre.bonon’s picture

andre.bonon
Primary language Portuguese, Brazil
commented
StatusFileSize
new php8-2-notice-pathauto-3328670-27.patch2.75 KB

Attaching patch from the MR diff to use in composer.json

santhosh@21’s picture

santhosh@21 commented

#2 works for me with php 8.2 and drupal 10.1.3

rymcveigh’s picture

rymcveigh
he/him/his
commented

It would be really nice if we could get this (now merged) change released to the most recent stable version of the module.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I filed #3388122: 8.x-1.12 Release Plan for php 8.2 and Drupal 10 support to plan the next release.

Based on reviewing the issue queue for critical/major issues, I think it could happen without any additional commits, but there is one additional issue that could be useful to commit.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3388122: 8.x-1.12 Release Plan for php 8.2 and Drupal 10 support