Problem/Motivation
When using this module and webprofiler, we can't add a new external entity type because ConfigurableExpressionFieldMapperBase use EntityTypeManager type instead of EntityTypeManagerInterface in constructor.
Steps to reproduce
- Install external_entities module
- Install webprofiler module
- Add a new external entity type
Error :
Argument 4 passed to Drupal\external_entities\FieldMapper\ConfigurableExpressionFieldMapperBase::__construct() must be an instance of Drupal\Core\Entity\EntityTypeManager, instance of Drupal\webprofiler\Entity\EntityManagerWrapper given
Proposed resolution
Use EntityTypeManagerInterface in ConfigurableExpressionFieldMapperBase, ExpressionFieldMapperBase and FieldMapperBase classes constructors.
Remaining tasks
Using EntityTypeManagerInterface in ConfigurableExpressionFieldMapperBase, ExpressionFieldMapperBase and FieldMapperBase classes constructors.
Issue fork external_entities-3315167
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
colin.eininger CreditAttribution: colin.eininger commentedComment #4
colin.eininger CreditAttribution: colin.eininger as a volunteer and commentedCreated a MR with a simple fix
Comment #5
pgrond CreditAttribution: pgrond at Grondtonen commentedLooks good to me! Thanks.
Comment #7
pgrond CreditAttribution: pgrond at Grondtonen commentedComment #8
pgrond CreditAttribution: pgrond at Grondtonen commented