Problem/Motivation

When using this module and webprofiler, we can't add a new external entity type because ConfigurableExpressionFieldMapperBase use EntityTypeManager type instead of EntityTypeManagerInterface in constructor.

Steps to reproduce

  1. Install external_entities module
  2. Install webprofiler module
  3. Add a new external entity type

Error :

Argument 4 passed to Drupal\external_entities\FieldMapper\ConfigurableExpressionFieldMapperBase::__construct() must be an instance of Drupal\Core\Entity\EntityTypeManager, instance of Drupal\webprofiler\Entity\EntityManagerWrapper given

Proposed resolution

Use EntityTypeManagerInterface in ConfigurableExpressionFieldMapperBase, ExpressionFieldMapperBase and FieldMapperBase classes constructors.

Remaining tasks

Using EntityTypeManagerInterface in ConfigurableExpressionFieldMapperBase, ExpressionFieldMapperBase and FieldMapperBase classes constructors.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

colin.eininger created an issue. See original summary.

colin.eininger’s picture

Issue summary: View changes

colin.eininger’s picture

Issue summary: View changes
Status: Needs work » Needs review

Created a MR with a simple fix

pgrond’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me! Thanks.

pgrond’s picture

Status: Reviewed & tested by the community » Fixed
pgrond’s picture

Status: Fixed » Closed (fixed)