DAM media and core media Labels looks same and creates confusion when using both together.
Remaining Task:

  • Update media type label to specify its DAM media types
  • Write update hook for existing customers

Before applying the patch:
Before applying the patch
After applying the patch:
After applying the patch

CommentFileSizeAuthor
#10 acquia_dam-3314708-media-type-label-should-be-different-10.patch3.97 KBrajeshreeputra
#9 acquia_dam-3314708-media-type-label-should-be-different-4.patch3.96 KBrajeshreeputra
#7 after-applying-the-patch.png256.26 KBrajeshreeputra
#6 before-applying-the-patch.png216.47 KBrajeshreeputra
#5 after-applying-the-patch.png254.25 KBrajeshreeputra
#4 acquia_dam-3314708-media-type-label-should-be-different-4.patch3.95 KBrajeshreeputra
Screen Shot 2022-10-11 at 5.25.55 PM.png216.47 KBrajeshreeputra

Issue fork acquia_dam-3314708

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rajeshreeputra created an issue. See original summary.

Rajeshreeputra opened merge request !3

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Title: Media type label should be different » DAM media type label should be different that core media types
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Assigned: rajeshreeputra » Unassigned
Status: Active » Needs review
StatusFileSize
new acquia_dam-3314708-media-type-label-should-be-different-4.patch3.95 KB

Here is the patch for the MR created.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
StatusFileSize
new after-applying-the-patch.png254.25 KB
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
StatusFileSize
new before-applying-the-patch.png216.47 KB
new after-applying-the-patch.png256.26 KB
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
StatusFileSize
new before-applying-the-patch.png216.47 KB
new after-applying-the-patch.png256.26 KB
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Issue summary: View changes
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
StatusFileSize
new acquia_dam-3314708-media-type-label-should-be-different-4.patch3.96 KB
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
StatusFileSize
new acquia_dam-3314708-media-type-label-should-be-different-10.patch3.97 KB
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Title: DAM media type label should be different that core media types » DAM media type label should be different than core media types
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented

I agree with this. It is confusing when you first install the module.

mglaman credited amangrover90.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Crediting amangrover90 who worked on the changes required in the link tabs

  • amangrover90 authored eb1dc9e7 on 1.0.x 
    Issue #3314708 by Rajeshreeputra, amangrover90: Change label and...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

This has been fixed and will improve all new sites – we did not modify existing configurations.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

(: modifying credit to credit myself for internal reviews and such.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Balu Ertl closed merge request !3