This ticket is going to have a super patch that contains one shot update for the following tickets:

* Accessibility improvements: https://www.drupal.org/project/elf/issues/3300085
* Allow to open external links using target="_blank": https://www.drupal.org/project/elf/issues/3300083
* Allow to override a class for external link: https://www.drupal.org/project/elf/issues/3300056

The reason for that is that all of these tickets are modifying same code and maintaining separate patches for each of them is not feasible, they also won't apply together.

Comments

dealancer created an issue. See original summary.

dealancer’s picture

Status: Active » Needs review
StatusFileSize
new8.31 KB

Here is super patch.

dealancer’s picture

StatusFileSize
new7.97 KB

Whoops, that patch should not contain info file changes. Rerolling.

jasonmce’s picture

Status: Needs review » Reviewed & tested by the community

I verified elf-3304604_super-patch-3.patch in a local test environment.

i-trokhanenko’s picture

i-trokhanenko’s picture

Status: Reviewed & tested by the community » Needs work

Hey guys, thanks for the patches. Could you please update patch #3 to the current 8.x-1.x branch? I've committed a couple of issues, so applying the current patch failed at src/Plugin/Filter/FilterElf.php:57

dealancer’s picture

Status: Needs work » Needs review
StatusFileSize
new7.26 KB

Thank you!

Here is a re rolled version of this patch. No changes, just making sure it applies. Also tested, works on my machine.

jasonmce’s picture

Status: Needs review » Reviewed & tested by the community

Confirmed re-roll applied cleanly for me.

  • 99b3f10 committed on 8.x-1.x
    Issue #3304604 by dealancer, jasonmce, i-trokhanenko: Super patch (...
i-trokhanenko’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.