Problem/Motivation

The #[AllowDynamicProperties] been merged into 1.8.1 release via https://github.com/phpstan/phpstan-src/pull/1478, but it was not enough to cover it properly. 1.8.2 should fix that and we should update to it when its available

Steps to reproduce

Proposed resolution

Upgrade to https://github.com/phpstan/phpstan/releases/tag/1.8.2 when it becomes available to allow testing PHP 8.2.

Remaining tasks

Await 1.8.2, update to it.

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

no

CommentFileSizeAuthor
#3 3298199-3.patch2.34 KBandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Issue tags: +PHPStan-0
Related issues: +#3274474: Fix 'Access to an undefined property' PHPStan L0 errors

There will be much more changes related to PHP 8.2 https://github.com/phpstan/phpstan-src/commit/22561e7f12e29bbcaec1b4c3fb... so it will need to re-check #3274474: Fix 'Access to an undefined property' PHPStan L0 errors

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Title: Upgrade phpstan/phpstan to 1.8.2, when available » Upgrade phpstan/phpstan to 1.8.2 for full support of PHP 8.2
Status: Postponed » Needs review
FileSize
3298199-3.patch2.34 KB

Here it is https://github.com/phpstan/phpstan/releases/tag/1.8.2

Spokje’s picture

Spokje
Primary language Dutch
CreditAttribution: Spokje as a volunteer commented
Status: Needs review » Reviewed & tested by the community

LGTM

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Title: Upgrade phpstan/phpstan to 1.8.2 for full support of PHP 8.2 » Upgrade phpstan/phpstan to 1.8.2 for support of PHP 8.2 #[\AllowDynamicProperties] attribute

Clearer title

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 94c7446e4c to 10.1.x and 9dc3928ba4 to 10.0.x. Thanks!

  • alexpott committed 94c7446 on 10.1.x 
    Issue #3298199 by andypost: Upgrade phpstan/phpstan to 1.8.2 for support...

  • alexpott committed 9dc3928 on 10.0.x 
    Issue #3298199 by andypost: Upgrade phpstan/phpstan to 1.8.2 for support...
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Thank you!next blocker is upgrade of
mglaman/phpstan-drupal
to 1.1.25 https://github.com/mglaman/phpstan-drupal/commit/8acaa1e4a15b266cfbd404c... it will unblock testing

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

Not clear why https://www.drupal.org/pift-ci-job/2420734 fails after this commit but locally it passes, hope next one will be #3298396: Upgrade composer requirement to 2.3.6 to prevent warnings on PHP 8.2

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue tags: +10.0.0 release notes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.