Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

CommentFileSizeAuthor
#15 encrypt-revert-project-bot-3297063-15.patch3.3 KBjcnventura
#6 Encryption profile testing.png123.65 KBameymudras
#6 Encryption profile.png134.73 KBameymudras
#6 Encrypt Module.png70.19 KBameymudras
#2 encrypt.3.x-dev.rector.patch18.74 KBproject update bot

Issue fork encrypt-3297063

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new encrypt.3.x-dev.rector.patch18.74 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
jaydev bhatt’s picture

jaydev bhatt commented
Assigned: Unassigned » jaydev bhatt
Issue summary: View changes

i will review this patch

jaydev bhatt’s picture

jaydev bhatt commented
Assigned: jaydev bhatt » Unassigned
Status: Needs review » Reviewed & tested by the community

i have test the bot patch this works great with Drupal-9.4.5 and Drupal 10.0.1
also have run the module through the upgrade_status module and the output has no remaining deprecated codes.

RTBC+1
Moving this to RTBC

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

@Jaydev Bhatt Thanks for reviewing. Did you test the functionality, or just check that the module can be enabled?

ameymudras’s picture

ameymudras commented
StatusFileSize
new Encrypt Module.png70.19 KB
new Encryption profile.png134.73 KB
new Encryption profile testing.png123.65 KB

Tested on Drupal 10.0.x, php 8.1 and key module v8.x-1.16

- Bot generated patch applies cleanly
- Was able to install the module without any issues
- Used Real-aes module with D10 compatibility patch because this module requires attest one encryption method
- Configuration form saves without any issue. Was able to create a new encryption profile and listed correctly
- No warnings / errors in the db log
- Upgrade status shows no other issues.
- Did a code review and no issues identified. Most of the code changes are related to Tests and looks safe to merge

RTBC for me too

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

To be honest, and this is a tiny nitpick just because it makes no sense...

The patch proposed by the bot removes support for Drupal 8, and then only changes the tests. It's no longer even possible to run tests here in Drupal 8, so removing D8 support just because the tests were updated is irrelevant.

I'd rather see that the module only drops D8 support when the D10 patch adds something that can only be found in Drupal 9 or above.

rlhawk made their first commit to this issue’s fork.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Drupal 10 porting day

Working during porting day.

Maybe one of the maintainers can chime in on #7.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented

I agree about not dropping support for Drupal 8 until necessary.

rlhawk opened merge request !3

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs work » Reviewed & tested by the community

  • rlhawk committed caaa513 on 8.x-3.x 
    Issue #3297063 by rlhawk, Project Update Bot, ameymudras, Jaydev Bhatt,...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Needs work

Three errors are returned when running tests; all of them are related to getPluginCollection:

Drupal\Tests\encrypt\Unit\Entity\EncryptionProfileTest::testGetEncryptionMethod
PHPUnit\Framework\MockObject\MethodCannotBeConfiguredException: Trying to configure method "getPluginCollection" which cannot be configured because it does not exist, has not been specified, is final, or is static
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new encrypt-revert-project-bot-3297063-15.patch3.3 KB

The update bot is a bit dumb at times. I've seen cases where tests pass just fine in D10 and the changes by the bot break the tests.

Let's see if reverting this set of changes by the bot restores the tests to pass.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

OK. All tests pass again. PHP 7.4, 8.0 and 8.1 and in Drupal 9 and 10.

I'm setting this to RTBC, as it is really not my code, just undoing part of what the update bot did.

  • 8d114d9 committed on 8.x-3.x 
    Issue #3297063 by jcnventura, Project Update Bot: Automated Drupal 10...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Fixed

Thanks, @jcnventura!

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Yay! Thanks 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.