Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

CommentFileSizeAuthor
#8 Screenshot 2023-04-14 at 10.46.47 AM.png125.93 KBsahil.goyal
#7 3296953-dfp-d10-7--interdiff.patch2.33 KBjedihe
#7 3296953-dfp-d10-7.patch16.64 KBjedihe
#6 dfp_d10-3296953-6.patch16.17 KBafsch
#4 dfp.1.x-dev.rector.patch15.79 KBproject update bot
#4 interdiff-last-bot.6675178.txt705 bytesproject update bot
#3 dfp.1.x-dev.rector.patch15.57 KBproject update bot
#3 interdiff-last-bot.6658520.txt419 bytesproject update bot
#2 dfp.1.x-dev.rector.patch15.95 KBproject update bot

Issue fork dfp-3296953

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new dfp.1.x-dev.rector.patch15.95 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6658520.txt419 bytes
new dfp.1.x-dev.rector.patch15.57 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6675178.txt705 bytes
new dfp.1.x-dev.rector.patch15.79 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
fmb’s picture

fmb commented
Issue summary: View changes

Hi, any plan for a D10 release? This could be a blocker for many projects. Thanks!

afsch’s picture

afsch
Location Otavalo
commented
StatusFileSize
new dfp_d10-3296953-6.patch16.17 KB

Adding a patch updating the info.yml file.

jedihe’s picture

jedihe commented
StatusFileSize
new 3296953-dfp-d10-7.patch16.64 KB
new 3296953-dfp-d10-7--interdiff.patch2.33 KB

Updated #6 so tests pass in Drupal 9.5.

sahil.goyal’s picture

sahil.goyal commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2023-04-14 at 10.46.47 AM.png125.93 KB

Thanx @jedihe for the patch, changes looks alright, and functionality works as expected by applying #7 on Drupal 10.1.x. Moving to RTBC, Please revert back if needed.

jedihe’s picture

jedihe commented

As for running the tests in D10, I was able to confirm they all pass doing this:

composer create-project drupal/recommended-project:^10 d10
cd d10
composer require mglaman/composer-drupal-lenient cweagans/composer-patches -n
composer config "allow-plugins.mglaman/composer-drupal-lenient" true -n
composer config "allow-plugins.cweagans/composer-patches" true -n
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/dfp"]'
composer require drupal/dfp
composer config --merge --json "extra.patches.drupal/dfp" '{"Drupal 10 compatibility": "https://www.drupal.org/files/issues/2023-04-13/3296953-dfp-d10-7.patch"}'
composer i
composer require drupal/core-dev:^10 phpspec/prophecy-phpunit:^2 --dev
php -S 127.0.0.1:8080 -t web &
SIMPLETEST_BASE_URL=http://127.0.0.1:8080 SIMPLETEST_DB=sqlite://localhost//dev/shm/tmp.sql vendor/bin/phpunit -c web/core web/modules/contrib/dfp/
jedihe’s picture

jedihe commented
jedihe’s picture

jedihe commented

In case it helps somebody: here's a set of patches to considerably improve DFP:

{
    "extra": {
        "patches": {
            "drupal/dfp": {
                "D10 compatibility": "https://www.drupal.org/files/issues/2023-04-13/3296953-dfp-d10-7.patch",
                "Support sync/async switching": "https://www.drupal.org/files/issues/2023-04-14/dfp-outdated-js-2905298-24--for-3296953-7.patch",
                "Lazy-loading support": "https://www.drupal.org/files/issues/2021-05-21/3179558-dfp-lazyload-8--for-2905298-17.patch",
                "Support out-of-page slots": "https://www.drupal.org/files/issues/2022-05-16/dfp-out-of-page-support-2905255-16.patch",
                "Add slot_id token": "https://www.drupal.org/files/issues/2020-02-25/dfp-slot-id-token-3116037-2.patch",
                "Add token browser": "https://www.drupal.org/files/issues/2021-05-21/dfp-add-token-browser-2905038-9.patch",
                "Multiple ads per ad slot": "https://www.drupal.org/files/issues/2022-05-16/dfp-multiple-ads-per-slot-3116576-9--for-2905298-22--2905255-16.patch",
                "Output JS slot definitions in proper order": "https://www.drupal.org/files/issues/2023-04-14/2837056-dfp-slot-js-definitions-reversed-9.patch"
            }   
        }
    }
}

DFP 1.2 + this patches currently pass tests both for D9.5 and D10.

aleix made their first commit to this issue’s fork.

aleix opened merge request !6

  • VladimirAus committed 4bec57f7 on 2.0.x authored by jedihe 
    Issue #3296953 by Project Update Bot, jedihe, aleix, afsch, sahil.goyal...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Reviewed & tested by the community » Fixed

Code added as a separate branch.
Thanks everyone for contributing. 🍻
Please test 🙏

VladimirAus closed merge request !6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

aleix’s picture

aleix
Primary language Catalan
Location Terrassa
commented

I'm sorry to read so late right now, I think that there's nothing left to do now, true?