Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
You have a few options for how to use this issue:
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Using the patches
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | simple_pass_reset-drupal-10-compatibility-3289646-12.patch | 526 bytes | carsonw |
| #11 | 3289646-drupal-10-compatibility-11.patch | 469 bytes | gold |
| #2 | simple_pass_reset.1.x-dev.rector.patch | 438 bytes | project update bot |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #4
lugir commentedComment #9
la vague illuminee commentedSorry for double merge request. :)
Comment #10
holo96 commented+ 1 RTBC
Not sure if there are active maintainers
Comment #11
goldThe patch at #3 is no longer applying when used with cewegans/composer-patches and a standard
composer require 'drupal/simple_pass_reset:^1.1'.I'm going to leave the patch at #3 as current though as that does still apply to the dev branch.
If people are needing this for a production environment and don't use dev branches in prod, the attached will work for you.
Comment #12
carsonwFor the life of me, I can't get the patches in #3 and #11 to work, so I'm trying this.
Comment #13
goldHmm... Odd. "It works for me." :)
@carsonw, I should be able to test this again this week. I'll let you know how it goes and if it applies fine I'll ditch my one.
Cheers for testing.
Comment #14
trevorbradley commentedNeither patch 11 or 12 is applying against drupal/simple_pass_reset:dev-1.x#4041f81.
Looks like a standard core/core_version_requirement fix - let me roll my own...
Ahh, it's identical to patch #2, which applies just fine against dev-1.x#4041f81
@carsonw, @Gold, I wonder if you're patching the dev version or the release version?
Comment #15
intrafusionComment #16
rymcveighThe latest patch works for us as well. It looks GTG to me.
Comment #17
tim-dielsI suggest we keep the patch from the update bot. The MR adds different constraints that are not necessary.
Comment #18
rszrama commentedMade the simple update and tested in a D10 site. I did not do a thorough test of the module, small as it is, for deprecations or PHP warnings, but I'll tag a release now that at least adds D10 support and we can catch any issues in follow-ups.
Comment #20
carsonwThanks Ryan! (Hope you're well)