Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new3.75 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
luke.leber’s picture

Issue summary: View changes
StatusFileSize
new7.37 KB

Resolve an uncaught deprecation for file_url_transform_relative.

luke.leber’s picture

Issue tags: +Drupal 10 porting day
luke.leber’s picture

Need to update the lower bound for D9 support; the file url generator service was added in 9.3.

luke.leber’s picture

Added related upstream issue for webp.

kristen pol’s picture

Issue tags: +Needs manual testing

Thanks for participating in porting day and updating the patch! Tagging for manual testing on Drupal 10. See instructions here:

https://www.drupal.org/community-initiatives/contribution-events-initiat...

project update bot’s picture

luke.leber’s picture

Issue summary: View changes
Status: Needs review » Postponed
luke.leber’s picture

Status: Postponed » Active

Let's get those tests firing now and see what else is broken.

luke.leber’s picture

StatusFileSize
new9.24 KB
luke.leber’s picture

Status: Active » Needs review

Setting to NR pending manual testing on 9.3.x, 9.4.x, 9.5.x, 10.0.x, and 10.1.x.

kristen pol’s picture

Working during porting day.

@Luke.Leber Given you are requesting testing on many versions, do you have a preferred way of testing that you can provide to make it easier for people to do the testing? Thanks.

luke.leber’s picture

Hi @Kristen Pol -

I think we might want to re-fire automated tests on this before devoting manual effort now, as https://www.drupal.org/project/drupal/issues/3192234 just landed today. I've been watching this issue rather closely and it has the real potential to be disruptive here for 10.1.x.

Overall, testing this module is pretty complex. The best place to start is by reading the documentation that ships with the module at https://www.drupal.org/docs/contributed-modules/responsive-image-preload.

kristen pol’s picture

Thank you for the details 👍

luke.leber’s picture

Looks like the test cases are passing against 10.1.x! I did not expect that, honestly.

I do think that the best manual tests should be against real sites here. The only sites that I manage are configured with <picture> elements only, they never use <img srcset...>. I should be able to do some manual testing this weekend. Overall manual tests should...

  1. Set up a variety of responsive image styles with various configurations.
  2. For each breakpoint
    1. For each multiplier that applies to the breakpoint
      1. Ensure that the appropriate asset is preloaded on the front-end (via network inspector).
kristen pol’s picture

Glad to hear the tests are working and thanks for the additional info 👍

project update bot’s picture

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

Therefore this patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #8662

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
martijn de wit’s picture

We are also only using the <picture> variation. Asked my self if I knew sites/agencies using an other case but couldn't find one.

Is this what holding up a D10 release? Guess there is a chance we can wait long before some one using other edge cases and finds this ticket....

Maybe you can make a D10 beta or RC version? So site that want to upgrade can do it with this module.

luke.leber’s picture

Hi Martijn, it hs been long enough to conclude that we will not be getting community feedback here, so I guess there's nothing truly holding up merging this in and cutting a new release.

I tend to prefer stable release tags for projects that I use in production for the security team coordination.

I'll try to get one out today.

  • 271df36d committed on 2.0.x
    Issue #3289350 by Project Update Bot, Luke.Leber: Automated Drupal 10...
luke.leber’s picture

Status: Needs review » Fixed

I'm going to close this issue out as fixed, 2.0.0 will be cut shortly.

There's a major breaking change between 1.0.x and 2.0.x in that the contributed webp project has been dropped. 1.0.x will remain in security support until Drupal 9 goes EoL.

  1. webp isn't ready for Drupal 10.
  2. There is native support in Drupal 10 that should be a replacement for webp.

Thanks for prodding me on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.