Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#22 migrate_file-d10-compatibility-3288621-22.patch744 bytesklimp
#10 migrate_file-d10-compatibility-3288621-10.patch2.01 KBrichardgaunt
#9 Migrated content with external file.png202.87 KBameymudras
#9 Running migration.png165.65 KBameymudras
#9 Migration config.png188.61 KBameymudras
#5 migrate_file.2.1.1.rector.patch1008 bytesproject update bot
#5 interdiff-last-bot.6675540.txt367 bytesproject update bot
#4 migrate_file.2.1.1.rector.patch738 bytesproject update bot
#4 interdiff-last-bot.6663487.txt510 bytesproject update bot
#3 migrate_file.2.1.1.rector.patch1.19 KBproject update bot
#3 interdiff-last-bot.6644173.txt510 bytesproject update bot
#2 migrate_file.2.1.1.rector.patch738 bytesproject update bot

Issue fork migrate_file-3288621

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new migrate_file.2.1.1.rector.patch738 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6644173.txt510 bytes
new migrate_file.2.1.1.rector.patch1.19 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6663487.txt510 bytes
new migrate_file.2.1.1.rector.patch738 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6675540.txt367 bytes
new migrate_file.2.1.1.rector.patch1008 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue summary: View changes
Issue tags: +Needs manual testing

This module needs functional testing on Drupal 10. Adding general instructions:

https://www.drupal.org/community-initiatives/contribution-events-initiat...

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Related issues: +#3288620: Automated Drupal 10 compatibility fixes

Add related issue: #3288620: Automated Drupal 10 compatibility fixes

ameymudras’s picture

ameymudras commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Migration config.png188.61 KB
new Running migration.png165.65 KB
new Migrated content with external file.png202.87 KB

Tested on Drupal 10 and php 8.1

- The patch applies cleanly
- The code changes are minor and only pertain to tests
- Created a new migration config and used the image_import and file_import plugin
- The migration worked without any issues and files were migrated
- No warnings / errors in the log and no issues found with code review

Marking this as RTBC

richardgaunt’s picture

richardgaunt commented
StatusFileSize
new migrate_file-d10-compatibility-3288621-10.patch2.01 KB

Added additional fix for deprecated contstant.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Status: Reviewed & tested by the community » Needs review

Thanks @RichardGaunt. Normally would request an interediff but this is a small patch and you said what you fixed.

Back to needs review given the change.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Drupal 10 porting day

Working during porting day. Tagging for visibility.

This can be tested again per #9 and #7.

alex.skrypnyk made their first commit to this issue’s fork.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

@ameymudras Are you able to provide more details on this step please?

Created a new migration config

ameymudras’s picture

ameymudras commented
Status: Needs review » Reviewed & tested by the community

Tested on Drupal 10 and php 8.1

- The patch #10 applies cleanly
- Was able to perform the migration
- Code review passing

Marking this as RTBC, not adding screenshots as not much has changed from the earlier patch

igorik’s picture

igorik commented

@drclaw, if it ipassed well, would be nice to make a new 2.1.2 version with D10 support
Thanks for your effort.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

+1, we are waiting for a D10 version of this module as well.

  • drclaw committed 9a801ac0 on 2.1.x authored by RichardGaunt 
    Issue #3288621 by Project Update Bot, alex.skrypnyk, RichardGaunt:...
drclaw’s picture

drclaw commented
Status: Reviewed & tested by the community » Fixed

Committed and new release has been rolled (2.1.2)! Thank you so much to everyone involved!!

2dareis2do’s picture

2dareis2do commented

Thank you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

klimp’s picture

klimp
Location Montréal, QC
commented
StatusFileSize
new migrate_file-d10-compatibility-3288621-22.patch744 bytes

Replaced FILE_STATUS_PERMANENT with Drupal\file\FileInterface::STATUS_PERMANENT in /src/Plugin/migrate/process/FileRemoteUrl.php

Probably this was overlooked before.

FILE:
web/modules/contrib/migrate_file/src/Plugin/migrate/process/FileRemoteUrl.php

STATUS         LINE                           MESSAGE
--------------------------------------------------------------------------------
Fix now        72   Call to deprecated constant FILE_STATUS_PERMANENT:
                    Deprecated in drupal:9.3.0 and is removed from
                    drupal:10.0.0. Use
                    Drupal\file\FileInterface::STATUS_PERMANENT or
                    \Drupal\file\FileInterface::setPermanent().
--------------------------------------------------------------------------------