Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#13 3288592-13.patch5.58 KBflocondetoile
#11 Screenshot from 2023-06-26 12-51-50.png17.63 KBdineshkumarbollu
#2 micro_path.1.x-dev.rector.patch734 bytesproject update bot

Issue fork micro_path-3288592

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new micro_path.1.x-dev.rector.patch734 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

gombi made their first commit to this issue’s fork.

gombi opened merge request !2

dineshkumarbollu’s picture

dineshkumarbollu commented
Issue summary: View changes

Hi

I reviewed MR!2 it still as some D10 issues.

ndor/bin/drush upgrade_status:analyze micro_site
[notice] Processing /var/www/html/vb9/web/modules/contrib/micro_site.

================================================================================
Micro site, 8.x-1.0-alpha8
Scanned on Fri, 06/23/2023 - 18:10

FILE: web/modules/contrib/micro_site/micro_site.module

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 96 Call to deprecated function file_create_url(). Deprecated in
drupal:9.3.0 and is removed from drupal:10.0.0. Use the
appropriate method on
\Drupal\Core\File\FileUrlGeneratorInterface instead.
--------------------------------------------------------------------------------
Check manually 96 Call to deprecated function file_url_transform_relative().
Deprecated in drupal:9.3.0 and is removed from
drupal:10.0.0. Use
Drupal\Core\File\FileUrlGenerator::transformRelative()
instead.
--------------------------------------------------------------------------------
Check manually 298 Call to deprecated function file_create_url(). Deprecated in
drupal:9.3.0 and is removed from drupal:10.0.0. Use the
appropriate method on
\Drupal\Core\File\FileUrlGeneratorInterface instead.
--------------------------------------------------------------------------------
Check manually 298 Call to deprecated function file_url_transform_relative().
Deprecated in drupal:9.3.0 and is removed from
drupal:10.0.0. Use
Drupal\Core\File\FileUrlGenerator::transformRelative()
instead.
--------------------------------------------------------------------------------
Check manually 384 Call to deprecated function file_create_url(). Deprecated in
drupal:9.3.0 and is removed from drupal:10.0.0. Use the
appropriate method on
\Drupal\Core\File\FileUrlGeneratorInterface instead.
--------------------------------------------------------------------------------
Check manually 384 Call to deprecated function file_url_transform_relative().
Deprecated in drupal:9.3.0 and is removed from
drupal:10.0.0. Use
Drupal\Core\File\FileUrlGenerator::transformRelative()
instead.
--------------------------------------------------------------------------------

FILE: web/modules/contrib/micro_site/src/Entity/Site.php

gombi’s picture

gombi commented

The Drupal Rector-provided patch was crashing my Drupal 10 site due to the usage of ModuleHandlerInterface::getImplementations() which was deprecated in Drupal 9.4 and removed in Drupal 10 (see https://www.drupal.org/node/3000490). I've updated the implementation to use ModuleHandlerInterface::invokeAllWith(). Consequently, I've updated the core version requirement to ^9.4 || ^10.

MR !2 should be ready for review.

gombi’s picture

gombi commented

Hi @dineshkumarbollu, thanks for taking the time to review.

I see that you ran upgrade_status:analyze for the micro_site module, not the micro_path module. Please check https://www.drupal.org/project/micro_site/issues/3288594 for the D10 issues relating to micro_site.

Thanks!

dineshkumarbollu’s picture

dineshkumarbollu commented

Hi @gombi

I will review the micro_path sorry for my bad.

Thanks

dineshkumarbollu’s picture

dineshkumarbollu commented
Assigned: Unassigned » dineshkumarbollu

I reviewed the MR it as one D10 issue, I will work on this.

vendor/bin/drush upgrade_status:analyze micro_path
[notice] Processing /var/www/html/vb9/web/modules/contrib/micro_path-3288592.

================================================================================
Micro Path, --
Scanned on Mon, 06/26/2023 - 12:45

FILE: web/modules/contrib/micro_path-3288592/src/MicroPathHelper.php

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 251 Relying on entity queries to check access by default is
deprecated in drupal:9.2.0 and an error will be thrown from
drupal:10.0.0. Call
\Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
TRUE or FALSE to specify whether access should be checked.
--------------------------------------------------------------------------------

dineshkumarbollu’s picture

dineshkumarbollu commented
Assigned: dineshkumarbollu » Unassigned
StatusFileSize
new Screenshot from 2023-06-26 12-51-50.png17.63 KB

I reviewed the MR!2 and fixed the D10 error which i mentioned in above comment. Also attaching D10 report.

Thanks

gombi’s picture

gombi commented

Hi @dineshkumarbollu, thank you, I completely missed this one!

Going to leave this under Needs review so that someone else can review both our changes :)

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
StatusFileSize
new 3288592-13.patch5.58 KB

  • gombi authored 267ad21d on 8.x-1.x 
    Issue #3288592 by gombi, dineshkumarbollu, flocondetoile: Automated...
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Status: Needs review » Fixed
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented

Thanks everyone

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.