Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#15 interdiff-11-15.txt1.31 KBLal_
#15 3287445-15.patch6.45 KBLal_
#13 3287445-11.patch5.94 KBLal_
#11 3287445-10.patch5.63 KBLal_
#9 interdiff.txt272 bytesLal_
#8 interdiff.txt272 bytesLal_
#8 3287445-8.patch5.74 KBLal_
#6 interdiff.txt2.43 KBLal_
#6 3287445-6.patch5.74 KBLal_
#5 3287445-5.patch2.91 KBsharayurajput
#3 facets_pretty_paths.1.x-dev.rector.patch2.5 KBproject update bot
#3 interdiff-last-bot.6642980.txt3.07 KBproject update bot
#2 facets_pretty_paths.1.x-dev.rector.patch414 bytesproject update bot

Issue fork facets_pretty_paths-3287445

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new facets_pretty_paths.1.x-dev.rector.patch414 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6642980.txt3.07 KB
new facets_pretty_paths.1.x-dev.rector.patch2.5 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0
sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput
Issue summary: View changes

Will work on this issue

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
StatusFileSize
new 3287445-5.patch2.91 KB

Module is not compatible with drupal 10 and there is no depricated code here checked with the Upgrade status module
providing patch-

Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new 3287445-6.patch5.74 KB
new interdiff.txt2.43 KB
Lal_’s picture

Lal_
He\Him
commented 
  1. +++ b/composer.json
@@ -17,15 +17,8 @@
-    "composer/installers": "^1.2",
-    "cweagans/composer-patches": "^1.4",
-    "dealerdirect/phpcodesniffer-composer-installer": "^0.5.0",
-    "drupal-composer/drupal-scaffold": "^2.2",
...
-    "drupal/coder": "^8.3",
...
-    "drush/drush": ">=9.7",
-    "openeuropa/drupal-core-require-dev": "^8.6 || ^9",

    I don't think we should add this inside the module composer... 

  2. +++ b/composer.json
@@ -49,16 +42,6 @@
-  "extra": {
-    "composer-exit-on-patch-failure": true,
-    "enable-patching": true,
-    "installer-paths": {
-      "build/core": ["type:drupal-core"],
-      "build/modules/contrib/{$name}": ["type:drupal-module"],
-      "build/profiles/contrib/{$name}": ["type:drupal-profile"],
-      "build/themes/contrib/{$name}": ["type:drupal-theme"]
-    }
-  },

    confuses php-stan

Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new 3287445-8.patch5.74 KB
new interdiff.txt272 bytes
Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new interdiff.txt272 bytes

wrong interdiff

Lal_’s picture

Lal_
He\Him
commented

okkai so the project is using task-runner to automate the setup...

Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new 3287445-10.patch5.63 KB
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

openeuropa/drupal-core-require-dev looks abandoned. It doesn't have 9.3 or 9.4 releases and hasn't had any releases in almost a year. I say remove it to get Composer running.

Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new 3287445-11.patch5.94 KB
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Blocked on search_api:

1) Drupal\Tests\facets_pretty_paths\Functional\PrettyPathsFunctionalTest::testPrettyPathsUrlProcessor
PHPUnit\Framework\Exception: Fatal error: Access level to Drupal\search_api\Plugin\views\query\SearchApiQuery::$offset must be public (as in class Drupal\views\Plugin\views\query\QueryPluginBase) in /var/www/html/modules/contrib/search_api/src/Plugin/views/query/SearchApiQuery.php on line 42
Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new 3287445-15.patch6.45 KB
new interdiff-11-15.txt1.31 KB
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

@Lal_ Curious if you were working on this as part of the Drupal 10 Global Porting Day?

Lal_’s picture

Lal_
He\Him
commented

@Kristen Pol No, I am working with Acquia as part of their D10 readiness.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks for letting me know:)

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Needs work

Tests are failing on D10, so this needs to be fixed as part of this issue, since its a D10 related change. Setting as needs work.

Lal_’s picture

Lal_
He\Him
commented
Related issues: +#3304531: Fix access level on $offset, $operator properties

I am confused about how this can be related to this issue, according to #14 it's related to search_api, since the issue is blocked how can this be tagged as Needs work?

project update bot’s picture

project update bot commented
Issue summary: View changes

deepakkm made their first commit to this issue’s fork.

deepakkm opened merge request !5

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 commented
Issue summary: View changes
Status: Needs work » Needs review

Hi @nkoporec,
Please review MR!5 and move ahead, now tests passing for D10 also.

deepakkm’s picture

deepakkm commented
Status: Needs review » Reviewed & tested by the community

Checked on local also all tests are passing , hence we can merge this.

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented

RTBC + 1

Hello @ Jimmy: Ideally, we would like to see the pre/stable released as soon as possible.

  • StryKaizer committed 1176383 on 8.x-1.x 
    Issue #3287445 by Lal_, Project Update Bot, deepakkm, ankitv18,...
ankitv18’s picture

ankitv18 commented
Related issues: -#3304531: Fix access level on $offset, $operator properties

To incorporate dependent modules of facets and pathauto both supports minimum constraints drupal version i.e 9.3, I pushed the changes in MR!5
This would resolve the new bug reported with issue-3327265 without any version_compare check

ankitv18’s picture

ankitv18 commented
Status: Reviewed & tested by the community » Needs review
ankitv18’s picture

ankitv18 commented

Hi @strykaizer,
Could you please take a look and do the needful?

ankitv18’s picture

ankitv18 commented
Related issues: +#3327265: Enabling module on Drupal 10 gives error: Call to undefined method Symfony\Component\HttpFoundation\RequestStack::getMasterRequest()

joseph.olstad closed merge request !5

joseph.olstad credited StryKaizer.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

see new release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.