Have a Varbase installation requirement ( notification, not a blocker) [#3277590]

Problem/Motivation

Requested by Razem

Having a Varbase installation requirement before installation will guide people on the needed PHP extensions and memory limit and time for the process

Maybe some links for a doc link

Have that as a notice only. The requirement will not block the process of installing

Linked to changes after:
Issue #3217859: Support PHP8.1 and MySQL 8 for Varbase ~9.0 and all used components with automated testing
✅ Developer Documentation support on feature change/addition

Changed
Requirements
PHP 7.4 or higher. PHP 8.0 is recommended.

Changed
Varbase Project Template for Platform.sh
The runtime the application uses
type: 'php:8.0'

Changed
Varbase Project Template for Lando
Lando PHP config
php: '8.0'

Steps to reproduce

When installing a new Varbase build, in Verify requirements phase, it's better to inform and guide people about the needed PHP extensions and memory limit and time for the process

Proposed resolution

Use hook_requirements to add requirements about those items.

Remaining tasks

✅ File an issue about this project
✅ Addition/Change/Update/Fix to this project
✅ Testing to ensure no regression
➖ Automated unit/functional testing coverage
➖ Developer Documentation support on feature change/addition
➖ User Guide Documentation support on feature change/addition
✅ Accessibility and Readability
✅ Code review from 1 Varbase core team member
✅ Full testing and approval
✅ Credit contributors
✅ Review with the product owner
✅ Update Release Notes and Update Helper on new feature change/addition
✅ Release varbase-9.0.7, varbase-10.0.0-alpha1

Varbase update type

✅ No Update
➖ Optional Update
➖ Forced Update
➖ Forced Update if Unchanged

User interface changes

Varbase requirements warnings

API changes

Data model changes

Release notes snippet

Issue #3277590 by Abdullah Yassin: Have a Varbase installation requirement ( notification, not a blocker)

Comment	File	Size	Author
#12	Screenshot from 2022-05-17 10-46-46.png	153.22 KB	Abdullah Yassin
#12	Add-varbase-installation-requirements-warnings-3277590-12.patch	2.58 KB	Abdullah Yassin
#11	Screenshot from 2022-05-08 11-06-17.png	121.55 KB	Abdullah Yassin

Issue fork varbase-3277590

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2 hidden branches

3277590-9-0-x

changes, plain diff MR !15

Check out this branch for the first time

Check out existing branch, if you already have it locally

3277590-9-1-x

changes, plain diff MR !16

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

28 April 2022 at 05:10

Abdullah Yassin created an issue. See original summary.

Comment #2

28 April 2022 at 06:21

Abdullah Yassin opened merge request !15

Comment #3

28 April 2022 at 06:25

Abdullah Yassin opened merge request !16

Comment #4

Abdullah Yassin commented 28 April 2022 at 06:28

Needs final wording.

Comment #5

Abdullah Yassin commented 28 April 2022 at 06:28

Assigned:	Abdullah Yassin	» Unassigned
Status:	Active	» Needs review

Comment #6

rajab natshah

he/him

commented 28 April 2022 at 06:55

Title:

Fix have a Varbase installation requirement ( notification, not a blocker)

» Have a Varbase installation requirement ( notification, not a blocker)

Comment #7

rajab natshah

he/him

commented 28 April 2022 at 07:39

Issue summary:	View changes
Status:	Needs review	» Needs work
Related issues:		+#3217859: Support PHP8.1 and MySQL 8 for Varbase ~9.0 and all used components with automated testing

Needs work on the following points:

Not to show the message. Only if the memory limit is less than 256M ( and not to show if it was -1 unlimited )
Change “Your” to “Current system” in messages.
Change “We recommend that you” to “Recommended for the current system”
Add logic to change the Recommended PHP version message based on the current system

Example:

if php version was < 7.4

Current system is using PHP 7.3
PHP 7.4 or higher. PHP 8.0 is recommended.

else if php version was 7.4

Current system is using PHP 7.4
PHP 8.0 is recommended.

It feels that this group of messages works for Server-side Requirements for Evaluation or Development
It could be nice to add a link for that. or let them know that these are recommended requirements for installation and development only.
And they can be changed for Server-side Requirements for Production

Linked to changes after:
Issue #3217859: Support PHP8.1 and MySQL 8 for Varbase ~9.0 and all used components with automated testing
✅ Developer Documentation support on feature change/addition

Changed
Requirements

PHP 7.4 or higher. PHP 8.0 is recommended.

Changed
Varbase Project Template for Platform.sh

The runtime the application uses
type: 'php:8.0'

Changed
Varbase Project Template for Lando

Lando PHP config
php: '8.0'

Comment #8

rajab natshah

he/him

commented 28 April 2022 at 08:59

Comment #9

Abdullah Yassin commented 8 May 2022 at 09:32

Version:

9.0.x-dev

» 10.0.x-dev

Comment #10

Abdullah Yassin commented 8 May 2022 at 09:33

Version:

10.0.x-dev

» 9.0.x-dev

Comment #11

Abdullah Yassin commented 8 May 2022 at 09:45

Status:

Needs work

» Needs review

Status	File	Size
new	Screenshot from 2022-05-08 11-06-17.png	121.55 KB

Changed on branch 9.0.x
Added php-yaml notic
This is the result:
hook_requiremenrs

Comment #12

Abdullah Yassin commented 17 May 2022 at 07:58

Status	File	Size
new	Add-varbase-installation-requirements-warnings-3277590-12.patch	2.58 KB
new	Screenshot from 2022-05-17 10-46-46.png	153.22 KB

Here is a patch for adding requirements warnings with a new words mentioned by Razem.
New requirements

Comment #13

rajab natshah

he/him

commented 17 May 2022 at 08:29

Issue summary:

View changes

Comment #14

17 May 2022 at 08:30

Rajab Natshah committed d5d5ef8 on 10.0.x authored by Abdullah Yassin

Issue #3277590 by Abdullah Yassin: Have a Varbase installation...

Comment #15

17 May 2022 at 08:31

Rajab Natshah committed 5a3ce43 on 9.0.x authored by Abdullah Yassin

Issue #3277590 by Abdullah Yassin: Have a Varbase installation...

Comment #16

rajab natshah

he/him

commented 17 May 2022 at 09:47

Assigned:	Unassigned	» mohammed j. razem
Category:	Bug report	» Task
Issue summary:	View changes
Issue tags:		+varbase-9.0.7, +varbase-10.0.0-alpha1, +php version, +PHP 8.0, +PHP 8.1, +memory_limit, +max_execution_time