Fix for PHP 8+

Operands must be boolean.

TypeError: Unsupported operand types: bool | array in override_node_options_form_alter() (line 241 of /vagrant/www/ethos7/sites/all/modules/contrib/override_node_options/override_node_options.module).

CommentFileSizeAuthor
#2 3274297.patch1.83 KBdjdevin

Issue fork override_node_options-3274297

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

djdevin created an issue. See original summary.

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new 3274297.patch1.83 KB
cindytwilliams’s picture

cindytwilliams commented
Status: Needs review » Reviewed & tested by the community

This patch applies, and fixes the error for me on PHP. 8.0

calbasi’s picture

calbasi
Primary language Catalan
Location Catalonia
commented

I can confirm that this patch solves the issue

aschiwi’s picture

aschiwi commented

Thanks for the patch, solved the problem for us!

ronino’s picture

ronino commented

Works for me, too. Thanks!

edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented

Please merge with dev.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Major

Confirming RTBC! Now that PHP 7.x is EOL, could we PLEASE have a new stable release with this?

This pops up on all sites!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue tags: +PHP 8.0
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Added an alternative approach using !empty() in the MR, so the maintainers may decide, which one they like more.

Anybody opened merge request !3

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented

I prefer the approach in #2, but the patch doesn't apply to the 7.x-1.x branch so it may need additional work.

  • opdavies committed 7e7d09d1 on 7.x-1.x authored by djdevin 
    Issue #3274297 by Anybody, djdevin: TypeError: Unsupported operand types...
opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented
Status: Reviewed & tested by the community » Fixed

I've re-applied the changes and committed them to the 7.x-1.x branch.

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented

Tagged as 7.x-1.15.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.