Problem/Motivation

To install migrate_plus:^6, the dependencies of this module should be more loose.

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - drupal/media_migration 1.0.0-alpha1 requires drupal/core ^8 -> found drupal/core[8.0.0-beta6, ..., 8.9.20] but it conflicts with your root composer.json require (^9.2@alpha).
    - drupal/media_migration[1.0.0-alpha2, ..., 1.0.0-alpha14] require drupal/migrate_plus ^4.2 || ^5 -> found drupal/migrate_plus[dev-4.x, dev-5.x, 4.2.0, 4.x-dev (alias of dev-4.x), 5.0.0-rc1, ..., 5.x-dev (alias of dev-5.x)] but it conflicts with your root composer.json require (^6@dev).
    - Root composer.json requires drupal/media_migration ^1.0@alpha -> satisfiable by drupal/media_migration[1.0.0-alpha1, ..., 1.0.0-alpha14].

Steps to reproduce

Proposed resolution

Remaining tasks

API changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

heddn created an issue. See original summary.

jonathan_hunt’s picture

Component: Documentation » Code
Status: Active » Needs review
xurizaemon’s picture

Attaching a copy of MR !6 as of 014103e5 as Gitlab MR URLs are subject to unexpected changes (ref #3204538).

markie’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies cleanly, but the composer.lock does not update and then when you try to update the migration suites, it does not allow. So if you want to use this before the next release, you will have to do the following:

1. `composer remove drupal/media_migration`
2. Update the repositories section of your composer.json to the following:

"repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/media_migration"
            ]
        },
        {
            "type": "git",
            "url": "git@git.drupal.org:issue/media_migration-3269743.git"
        }
]

3. `composer require drupal/media_migration:dev-3269743-support-drupal-10`
4. `composer require drupal/migrate_plus drupal/migrate_tools drupal/migrate_upgrade -W`

make sure you remove the patch..

@see https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa...

huzooka’s picture

Title: Support Drupal 10 / Migrate Plus >=4.2 » [PP-1] Support Drupal 10 / Migrate Plus >=4.2
Status: Reviewed & tested by the community » Postponed
Related issues: +#3263827: Make Migrate Magician compatible with Drupal core 10.x

Thank you all!

I'm postponing this on #3263827: Make Migrate Magician compatible with Drupal core 10.x.
Right after it gets solved, I will merge this PR.

jastraat’s picture

Pinging here since it looks like the issue in comment 6 was solved and part of a new Migrate Magician release.

huzooka’s picture

Title: [PP-1] Support Drupal 10 / Migrate Plus >=4.2 » Support Drupal 10 / Migrate Plus >=4.2
Status: Postponed » Needs work

This isn't postponed anymore.

Christopher Riley’s picture

Any word on getting a commit done on this?

xurizaemon’s picture

Status: Needs work » Needs review

Back to needs review with the proposed change.

proteo’s picture

I've tested the change and, while the patch applies cleanly and everything seems to work, I couldn't do the actual upgrade as Composer still sees the previous version constrain in the composer.lock file.

I added the patch to composer.json (using cweagans/composer-patches), then removed and required the project again with no luck (probably because of some caching?).

Anyway, I had to delete the lock file and run composer install for Composer to be able to finally see the changes and upgrade to Migrate Plus 6.0

huzooka’s picture

Test dependencies also should be Drupal 10 compatible.

damienmckenna’s picture

Test dependencies also should be Drupal 10 compatible.

Then please refocus this on compatibility with Migrate Plus 6 rather than blocking D9 sites from upgrading Migrate Plus and Migrate Tools.

damienmckenna’s picture

Title: Support Drupal 10 / Migrate Plus >=4.2 » Support Migrate Plus >=4.2
Issue summary: View changes
StatusFileSize
new332 bytes

Given #3297617 exists for actual Drupal 10 compatibility, let's focus this on just Migrate Plus 6 support.

damienmckenna’s picture

Status: Needs work » Needs review
damienmckenna’s picture

StatusFileSize
new579 bytes

Updated migrate_tools too.

pianomansam’s picture

Could we get some movement on this? I am unable to install this module with the patch method, and I cannot use the composer repository method as the issue fork is quite a bit behind dev.

rosk0’s picture

Priority: Normal » Major
StatusFileSize
new640 bytes
new394 bytes

Based the latest test run , it looks to me that migrate_upgrade constraint should be updated as well.

At the moment Drupal CI doesn't allow us to test changes to composer.json . From https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-f...

Tests of merge requests on the module will fail without a composer.json file, as will tests of patches that change the dependencies.

So I'm bumping priority in this regard - these changes should be merged ASAP. There is no big changes that could break client websites, also we are still in alpha here , so that is kinda allowed ;) .

pianomansam’s picture

For what it's worth, I rebased the issue branch off 8.x-1.x-dev so it has the latest code. This allows me to use the composer repo method.

drupalninja99’s picture

I am not sure how to test this? Can we get composer instructions or can we go ahead and merge?

damienmckenna’s picture

The merge request needs work to follow what's on the latest patch.

pianomansam’s picture

@DamienMcKenna the pull request has been updated with the updates in the latest patch.

@drupalninja99 if you would like to test the work in the feature branch, you can follow the instructions in #5

chrissnyder’s picture

What else needs to be done to get this work into a new release?

heddn’s picture

Title: Support Migrate Plus >=4.2 » Support Migrate Plus >=4.2 and Drupal 10
Assigned: Unassigned » heddn

Working on test failures.

heddn’s picture

I futzed around a long time with the RDF and Color modules test coverage. There isn't any much of a path forward for those 2 modules, they are making tests hard and in Drupal 10.0 they were moved out of core. For the sake of expediency in tests, I've removed test coverage for them. It is just easier to do that for something that has very little future life.

That said, tests are now green again on 9.4 and 10.0/10.1. I found a small bug in Migrate Upgrade 4.x while working on the test coverage here (fixed already and new tag released). All that is left here is for someone to review and someone to commit the code.

heddn’s picture

Status: Needs review » Fixed

I think that merging this means that this can be fixed.

  • heddn committed d369908a on 8.x-1.x
    Issue #3269743: Support Drupal 10 / Migrate Plus >=4.2
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.